ASF Bugzilla – Attachment 35737 Details for
Bug 61616
mod_proxy_connect: stall and connection loss on bi-directional traffic
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
fixes a busy loop trying to shutdown a disconnected socket
fix-epoll-busy-loop-on-disconnected-sockets.diff (text/plain), 1.34 KB, created by
Carsten Wolff
on 2018-02-22 09:17:04 UTC
(
hide
)
Description:
fixes a busy loop trying to shutdown a disconnected socket
Filename:
MIME Type:
Creator:
Carsten Wolff
Created:
2018-02-22 09:17:04 UTC
Size:
1.34 KB
patch
obsolete
>commit 23afdc99606e82b0b87992ff4d88c187ec1ff498 >Author: root <root@debian8-build.lan> >Date: Wed Feb 21 22:29:27 2018 +0100 > > don't bother proceeding on broken sockets > >diff --git a/modules/proxy/mod_proxy_connect.c b/modules/proxy/mod_proxy_connect.c >index baa1499..f26ffdd 100644 >--- a/modules/proxy/mod_proxy_connect.c >+++ b/modules/proxy/mod_proxy_connect.c >@@ -545,8 +545,17 @@ static int proxy_connect_handler(request_rec *r, proxy_worker *worker, > ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, > "%s write shutdown", conns[out].name); > #endif >- apr_socket_shutdown(conns[out].pfd.desc.s, 1); >+ rv = apr_socket_shutdown(conns[out].pfd.desc.s, 1); > conns[out].shutdown |= PROXY_SHUTDOWN_WRITE; >+ /* broken socket, give up */ >+ if ( rv != APR_SUCCESS ) { >+ done = 1; >+#ifdef DEBUGGING >+ ap_log_rerror(APLOG_MARK, APLOG_DEBUG, rv, r, >+ "%s write shutdown failed. Bailing out.", >+ conns[out].name); >+#endif >+ } > } > else { > pollset_add_conn(pollset, &conns[in], APR_POLLIN);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 61616
:
35421
|
35422
|
35423
|
35424
|
35425
|
35426
|
35427
|
35429
|
35430
|
35431
|
35432
|
35442
|
35443
|
35446
|
35447
|
35512
|
35513
|
35620
|
35621
|
35623
|
35639
| 35737 |
35738
|
35739
|
35772
|
35774
|
35776
|
35783
|
35784
|
35786
|
35787
|
35789