Attachment 12178 Details for Bug 28875 – The re-written patch to fix this problem in ErrorReportValve.

[patch] The re-written patch to fix this problem in ErrorReportValve.

ErrorReportValve.patch (text/plain), 1.43 KB, created by Kan Ogawa on 2004-07-21 04:31:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kan Ogawa

Created: 2004-07-21 04:31:23 UTC

Size: 1.43 KB

patch

obsolete

>Index: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/ErrorReportValve.java
>===================================================================
>RCS file: /home/cvspublic/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/ErrorReportValve.java,v
>retrieving revision 1.21
>diff -u -w -r1.21 ErrorReportValve.java
>--- jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/ErrorReportValve.java	27 Jun 2004 23:56:23 -0000	1.21
>+++ jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/ErrorReportValve.java	17 Jul 2004 20:59:20 -0000
>@@ -284,19 +284,17 @@
> 
>         try {
> 
>-            Writer writer = response.getReporter();
>-
>-            if (writer != null) {
>-
>-                Locale locale = Locale.getDefault();
>-
>                 try {
>                 	response.setContentType("text/html");
>-                	response.setLocale(locale);
>+                response.setCharacterEncoding("utf-8");
>                 } catch (Throwable t) {
>                     if (container.getLogger().isDebugEnabled())
>                         container.getLogger().debug("status.setContentType", t);
>                 }
>+
>+            Writer writer = response.getReporter();
>+
>+            if (writer != null) {
> 
>                 // If writer is null, it's an indication that the response has
>                 // been hard committed already, which should never happen
>

Actions: View | Diff

Attachments on bug 28875: 11496 | 11497 | 11507 | 11508 | 12178