ASF Bugzilla – Attachment 12620 Details for
Bug 29485
Undeploy considered dangerous
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
HTMLManagerServlet
HTMLManager5Patch.txt (text/plain), 2.83 KB, created by
Vitor Buitoni
on 2004-09-02 19:18:30 UTC
(
hide
)
Description:
HTMLManagerServlet
Filename:
MIME Type:
Creator:
Vitor Buitoni
Created:
2004-09-02 19:18:30 UTC
Size:
2.83 KB
patch
obsolete
>Index: HTMLManagerServlet.java >=================================================================== >RCS file: /home/cvspublic/jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/HTMLManagerServlet.java,v >retrieving revision 1.12 >diff -u -r1.12 HTMLManagerServlet.java >--- HTMLManagerServlet.java 26 May 2004 16:41:49 -0000 1.12 >+++ HTMLManagerServlet.java 2 Sep 2004 19:10:25 -0000 >@@ -350,6 +350,7 @@ > String appsStop = sm.getString("htmlManagerServlet.appsStop"); > String appsReload = sm.getString("htmlManagerServlet.appsReload"); > String appsUndeploy = sm.getString("htmlManagerServlet.appsUndeploy"); >+ String appsUndeployConfirm = sm.getString("htmlManagerServlet.appsUndeployConfirm"); > > Iterator iterator = sortedContextPathsMap.entrySet().iterator(); > while (iterator.hasNext()) { >@@ -381,7 +382,7 @@ > writer.print > (MessageFormat.format(APPS_ROW_DETAILS_SECTION, args)); > >- args = new Object[8]; >+ args = new Object[9]; > args[0] = response.encodeURL > (request.getContextPath() + > "/html/start?path=" + displayPath); >@@ -394,10 +395,11 @@ > (request.getContextPath() + > "/html/reload?path=" + displayPath); > args[5] = appsReload; >- args[6] = response.encodeURL >+ args[6] = appsUndeployConfirm; >+ args[7] = response.encodeURL > (request.getContextPath() + > "/html/undeploy?path=" + displayPath); >- args[7] = appsUndeploy; >+ args[8] = appsUndeploy; > if (context.getPath().equals(this.context.getPath())) { > writer.print(MessageFormat.format( > MANAGER_APP_ROW_BUTTON_SECTION, args)); >@@ -584,7 +586,7 @@ > " {1} \n" + > " {3} \n" + > " {5} \n" + >- " {7} \n" + >+ " {8} \n" + > " </small>\n" + > " </td>\n" + > "</tr>\n"; >@@ -595,7 +597,7 @@ > " {1} \n" + > " <a href=\"{2}\">{3}</a> \n" + > " <a href=\"{4}\">{5}</a> \n" + >- " <a href=\"{6}\">{7}</a> \n" + >+ " <a onclick=\"return confirm(''{6}'');\" href=\"{7}\">{8}</a> \n" + > " </small>\n" + > " </td>\n" + > "</tr>\n"; >@@ -606,7 +608,7 @@ > " <a href=\"{0}\">{1}</a> \n" + > " {3} \n" + > " {5} \n" + >- " <a href=\"{6}\">{7}</a> \n" + >+ " <a onclick=\"return confirm(''{6}'');\" href=\"{7}\">{8}</a> \n" + > " </small>\n" + > " </td>\n" + > "</tr>\n";
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 29485
: 12620 |
12621