Index: UpdateTagSupport.java =================================================================== RCS file: /home/cvspublic/jakarta-taglibs/standard/src/org/apache/taglibs/standard/tag/common/sql/UpdateTagSupport.java,v retrieving revision 1.29 diff -u -r1.29 UpdateTagSupport.java --- UpdateTagSupport.java 19 Oct 2004 20:47:15 -0000 1.29 +++ UpdateTagSupport.java 15 Dec 2004 00:06:58 -0000 @@ -151,14 +151,22 @@ } int result = 0; + PreparedStatement ps = null; try { - PreparedStatement ps = conn.prepareStatement(sqlStatement); + ps = conn.prepareStatement(sqlStatement); setParameters(ps, parameters); result = ps.executeUpdate(); - ps.close(); } catch (Throwable e) { throw new JspException(sqlStatement + ": " + e.getMessage(), e); + } finally { + if (ps != null) { + try { + ps.close(); + } catch (SQLException sqe) { + throw new JspException(sqe.getMessage(), sqe); + } + } } if (var != null) pageContext.setAttribute(var, new Integer(result), scope);