ASF Bugzilla – Attachment 19797 Details for
Bug 28744
Excel will crash when opening xls-files with images.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch for Bug 28744
27571.patch (text/plain), 1.42 KB, created by
Yegor Kozlov
on 2007-03-26 05:19:39 UTC
(
hide
)
Description:
Patch for Bug 28744
Filename:
MIME Type:
Creator:
Yegor Kozlov
Created:
2007-03-26 05:19:39 UTC
Size:
1.42 KB
patch
obsolete
>Index: src/java/org/apache/poi/hssf/record/DrawingGroupRecord.java >=================================================================== >--- src/java/org/apache/poi/hssf/record/DrawingGroupRecord.java (revision 522479) >+++ src/java/org/apache/poi/hssf/record/DrawingGroupRecord.java (working copy) >@@ -113,7 +113,7 @@ > while (writtenRawData < rawData.length) > { > int segmentLength = Math.min( rawData.length - writtenRawData, MAX_DATA_SIZE); >- if (writtenRawData / MAX_DATA_SIZE >= 2) >+ if (rawData.length > MAX_DATA_SIZE && writtenRawData >= MAX_DATA_SIZE) > writeContinueHeader( data, offset, segmentLength ); > else > writeHeader( data, offset, segmentLength ); >Index: src/java/org/apache/poi/ddf/EscherBSERecord.java >=================================================================== >--- src/java/org/apache/poi/ddf/EscherBSERecord.java (revision 522479) >+++ src/java/org/apache/poi/ddf/EscherBSERecord.java (working copy) >@@ -168,7 +168,7 @@ > */ > public int getRecordSize() > { >- return 8 + 1 + 1 + 16 + 2 + 4 + 4 + 4 + 1 + 1 + 1 + 1 + field_12_blipRecord.getRecordSize() + (remainingData == null ? 0 : remainingData.length); >+ return 8 + 1 + 1 + 16 + 2 + 4 + 4 + 4 + 1 + 1 + 1 + 1 + (field_12_blipRecord == null ? 0 : field_12_blipRecord.getRecordSize()) + (remainingData == null ? 0 : remainingData.length); > } > > /**
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 28744
:
19781
|
19782
|
19783
|
19784
|
19785
|
19786
|
19787
|
19788
| 19797