ASF Bugzilla – Attachment 20457 Details for
Bug 42806
apr_atomic problems
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
mutex implementation volatile qualifier removal
apr-atomic-barrier-mutex.patch (text/plain), 2.95 KB, created by
Davi Arnaut
on 2007-07-05 12:14:38 UTC
(
hide
)
Description:
mutex implementation volatile qualifier removal
Filename:
MIME Type:
Creator:
Davi Arnaut
Created:
2007-07-05 12:14:38 UTC
Size:
2.95 KB
patch
obsolete
>Index: apr/atomic/unix/mutex.c >=================================================================== >--- apr.orig/atomic/unix/mutex.c >+++ apr/atomic/unix/mutex.c >@@ -73,7 +73,7 @@ APR_DECLARE(apr_status_t) apr_atomic_ini > return APR_SUCCESS; > } > >-static APR_INLINE apr_thread_mutex_t *mutex_hash(volatile apr_uint32_t *mem) >+static APR_INLINE apr_thread_mutex_t *mutex_hash(apr_uint32_t *mem) > { > apr_thread_mutex_t *mutex = hash_mutex[ATOMIC_HASH(mem)]; > >@@ -93,12 +93,12 @@ APR_DECLARE(apr_status_t) apr_atomic_ini > > #endif /* APR_HAS_THREADS */ > >-APR_DECLARE(apr_uint32_t) apr_atomic_read32(volatile apr_uint32_t *mem) >+APR_DECLARE(apr_uint32_t) apr_atomic_read32(apr_uint32_t *mem) > { > return *mem; > } > >-APR_DECLARE(void) apr_atomic_set32(volatile apr_uint32_t *mem, apr_uint32_t val) >+APR_DECLARE(void) apr_atomic_set32(apr_uint32_t *mem, apr_uint32_t val) > { > DECLARE_MUTEX_LOCKED(mutex, mem); > >@@ -107,7 +107,7 @@ APR_DECLARE(void) apr_atomic_set32(volat > MUTEX_UNLOCK(mutex); > } > >-APR_DECLARE(apr_uint32_t) apr_atomic_add32(volatile apr_uint32_t *mem, apr_uint32_t val) >+APR_DECLARE(apr_uint32_t) apr_atomic_add32(apr_uint32_t *mem, apr_uint32_t val) > { > apr_uint32_t old_value; > DECLARE_MUTEX_LOCKED(mutex, mem); >@@ -120,19 +120,19 @@ APR_DECLARE(apr_uint32_t) apr_atomic_add > return old_value; > } > >-APR_DECLARE(void) apr_atomic_sub32(volatile apr_uint32_t *mem, apr_uint32_t val) >+APR_DECLARE(void) apr_atomic_sub32(apr_uint32_t *mem, apr_uint32_t val) > { > DECLARE_MUTEX_LOCKED(mutex, mem); > *mem -= val; > MUTEX_UNLOCK(mutex); > } > >-APR_DECLARE(apr_uint32_t) apr_atomic_inc32(volatile apr_uint32_t *mem) >+APR_DECLARE(apr_uint32_t) apr_atomic_inc32(apr_uint32_t *mem) > { > return apr_atomic_add32(mem, 1); > } > >-APR_DECLARE(int) apr_atomic_dec32(volatile apr_uint32_t *mem) >+APR_DECLARE(int) apr_atomic_dec32(apr_uint32_t *mem) > { > apr_uint32_t new; > DECLARE_MUTEX_LOCKED(mutex, mem); >@@ -145,8 +145,8 @@ APR_DECLARE(int) apr_atomic_dec32(volati > return new; > } > >-APR_DECLARE(apr_uint32_t) apr_atomic_cas32(volatile apr_uint32_t *mem, apr_uint32_t with, >- apr_uint32_t cmp) >+APR_DECLARE(apr_uint32_t) apr_atomic_cas32(apr_uint32_t *mem, apr_uint32_t with, >+ apr_uint32_t cmp) > { > apr_uint32_t prev; > DECLARE_MUTEX_LOCKED(mutex, mem); >@@ -161,7 +161,7 @@ APR_DECLARE(apr_uint32_t) apr_atomic_cas > return prev; > } > >-APR_DECLARE(apr_uint32_t) apr_atomic_xchg32(volatile apr_uint32_t *mem, apr_uint32_t val) >+APR_DECLARE(apr_uint32_t) apr_atomic_xchg32(apr_uint32_t *mem, apr_uint32_t val) > { > apr_uint32_t prev; > DECLARE_MUTEX_LOCKED(mutex, mem); >@@ -174,7 +174,7 @@ APR_DECLARE(apr_uint32_t) apr_atomic_xch > return prev; > } > >-APR_DECLARE(void*) apr_atomic_casptr(volatile void **mem, void *with, const void *cmp) >+APR_DECLARE(void*) apr_atomic_casptr(void **mem, void *with, void *cmp) > { > void *prev; > DECLARE_MUTEX_LOCKED(mutex, *mem);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 42806
:
20437
|
20438
|
20439
|
20440
|
20441
|
20456
| 20457 |
20458
|
20459
|
20460
|
20461
|
20462
|
20463
|
20464
|
20465
|
20466
|
20468