ASF Bugzilla – Attachment 20458 Details for
Bug 42806
apr_atomic problems
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
builtins implementation volatile qualifier removal
apr-atomic-barrier-builtins.patch (text/plain), 2.17 KB, created by
Davi Arnaut
on 2007-07-05 12:15:29 UTC
(
hide
)
Description:
builtins implementation volatile qualifier removal
Filename:
MIME Type:
Creator:
Davi Arnaut
Created:
2007-07-05 12:15:29 UTC
Size:
2.17 KB
patch
obsolete
>Index: apr/atomic/unix/builtins.c >=================================================================== >--- apr.orig/atomic/unix/builtins.c >+++ apr/atomic/unix/builtins.c >@@ -23,50 +23,54 @@ APR_DECLARE(apr_status_t) apr_atomic_ini > return APR_SUCCESS; > } > >-APR_DECLARE(apr_uint32_t) apr_atomic_read32(volatile apr_uint32_t *mem) >+APR_DECLARE(apr_uint32_t) apr_atomic_read32(apr_uint32_t *mem) > { >+ __sync_synchronize(); >+ > return *mem; > } > >-APR_DECLARE(void) apr_atomic_set32(volatile apr_uint32_t *mem, apr_uint32_t val) >+APR_DECLARE(void) apr_atomic_set32(apr_uint32_t *mem, apr_uint32_t val) > { > *mem = val; >+ >+ __sync_synchronize(); > } > >-APR_DECLARE(apr_uint32_t) apr_atomic_add32(volatile apr_uint32_t *mem, apr_uint32_t val) >+APR_DECLARE(apr_uint32_t) apr_atomic_add32(apr_uint32_t *mem, apr_uint32_t val) > { > return __sync_fetch_and_add(mem, val); > } > >-APR_DECLARE(void) apr_atomic_sub32(volatile apr_uint32_t *mem, apr_uint32_t val) >+APR_DECLARE(void) apr_atomic_sub32(apr_uint32_t *mem, apr_uint32_t val) > { > __sync_fetch_and_sub(mem, val); > } > >-APR_DECLARE(apr_uint32_t) apr_atomic_inc32(volatile apr_uint32_t *mem) >+APR_DECLARE(apr_uint32_t) apr_atomic_inc32(apr_uint32_t *mem) > { > return __sync_fetch_and_add(mem, 1); > } > >-APR_DECLARE(int) apr_atomic_dec32(volatile apr_uint32_t *mem) >+APR_DECLARE(int) apr_atomic_dec32(apr_uint32_t *mem) > { > return __sync_sub_and_fetch(mem, 1); > } > >-APR_DECLARE(apr_uint32_t) apr_atomic_cas32(volatile apr_uint32_t *mem, apr_uint32_t with, >+APR_DECLARE(apr_uint32_t) apr_atomic_cas32(apr_uint32_t *mem, apr_uint32_t with, > apr_uint32_t cmp) > { > return __sync_val_compare_and_swap(mem, cmp, with); > } > >-APR_DECLARE(apr_uint32_t) apr_atomic_xchg32(volatile apr_uint32_t *mem, apr_uint32_t val) >+APR_DECLARE(apr_uint32_t) apr_atomic_xchg32(apr_uint32_t *mem, apr_uint32_t val) > { > __sync_synchronize(); > > return __sync_lock_test_and_set(mem, val); > } > >-APR_DECLARE(void*) apr_atomic_casptr(volatile void **mem, void *with, const void *cmp) >+APR_DECLARE(void*) apr_atomic_casptr(void **mem, void *with, void *cmp) > { > return (void*) __sync_val_compare_and_swap(mem, cmp, with); > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 42806
:
20437
|
20438
|
20439
|
20440
|
20441
|
20456
|
20457
| 20458 |
20459
|
20460
|
20461
|
20462
|
20463
|
20464
|
20465
|
20466
|
20468