[patch] netware implementation volatile qualifier removal

apr-atomic-barrier-netware.patch (text/plain), 2.63 KB, created by Davi Arnaut on 2007-07-05 12:22:32 UTC

(hide)

Description: netware implementation volatile qualifier removal

Filename:

MIME Type:

Creator: Davi Arnaut

Created: 2007-07-05 12:22:32 UTC

Size: 2.63 KB

patch

obsolete

>Remove volatile qualifiers, and regarding to memory barriers, the Novell developer >kit documentation "NDK: Libraries for C (LibC), Volume 2; Section I, General C >Services; Atomic Functions", says: > >"An atomic function is guaranteed to complete its memory operation before any >other processor or bus agent can access the same memory." > >So I presume that the atomic functions issues memory barriers. > >Index: apr/atomic/netware/apr_atomic.c >=================================================================== >--- apr.orig/atomic/netware/apr_atomic.c >+++ apr/atomic/netware/apr_atomic.c >@@ -24,47 +24,47 @@ APR_DECLARE(apr_status_t) apr_atomic_ini > return APR_SUCCESS; > } > >-APR_DECLARE(apr_uint32_t) apr_atomic_add32(volatile apr_uint32_t *mem, apr_uint32_t val) >+APR_DECLARE(apr_uint32_t) apr_atomic_add32(apr_uint32_t *mem, apr_uint32_t val) > { > return atomic_xchgadd((unsigned long *)mem,(unsigned long)val); > } > >-APR_DECLARE(void) apr_atomic_sub32(volatile apr_uint32_t *mem, apr_uint32_t val) >+APR_DECLARE(void) apr_atomic_sub32(apr_uint32_t *mem, apr_uint32_t val) > { > atomic_sub((unsigned long *)mem,(unsigned long)val); > } > >-APR_DECLARE(apr_uint32_t) apr_atomic_inc32(volatile apr_uint32_t *mem) >+APR_DECLARE(apr_uint32_t) apr_atomic_inc32(apr_uint32_t *mem) > { > return atomic_xchgadd((unsigned long *)mem, 1); > } > >-APR_DECLARE(void) apr_atomic_set32(volatile apr_uint32_t *mem, apr_uint32_t val) >+APR_DECLARE(void) apr_atomic_set32(apr_uint32_t *mem, apr_uint32_t val) > { > *mem = val; > } > >-APR_DECLARE(apr_uint32_t) apr_atomic_read32(volatile apr_uint32_t *mem) >+APR_DECLARE(apr_uint32_t) apr_atomic_read32(apr_uint32_t *mem) > { > return *mem; > } > >-APR_DECLARE(apr_uint32_t) apr_atomic_cas32(volatile apr_uint32_t *mem, apr_uint32_t with,apr_uint32_t cmp) >+APR_DECLARE(apr_uint32_t) apr_atomic_cas32(apr_uint32_t *mem, apr_uint32_t with,apr_uint32_t cmp) > { > return atomic_cmpxchg((unsigned long *)mem,(unsigned long)cmp,(unsigned long)with); > } > >-APR_DECLARE(apr_uint32_t) apr_atomic_xchg32(volatile apr_uint32_t *mem, apr_uint32_t val) >+APR_DECLARE(apr_uint32_t) apr_atomic_xchg32(apr_uint32_t *mem, apr_uint32_t val) > { > return atomic_xchg((unsigned long *)mem,(unsigned long)val); > } > >-APR_DECLARE(int) apr_atomic_dec32(volatile apr_uint32_t *mem) >+APR_DECLARE(int) apr_atomic_dec32(apr_uint32_t *mem) > { > return (atomic_xchgadd((unsigned long *)mem, 0xFFFFFFFF) - 1); > } > >-APR_DECLARE(void *) apr_atomic_casptr(volatile void **mem, void *with, const void *cmp) >+APR_DECLARE(void *) apr_atomic_casptr(void **mem, void *with, void *cmp) > { > return (void*)atomic_cmpxchg((unsigned long *)mem,(unsigned long)cmp,(unsigned long)with); > } View Attachment As Diff View Attachment As Raw

This is ASF Bugzilla: the Apache Software Foundation bug system. In case of problems with the functioning of ASF Bugzilla, please contact bugzilla-admin@apache.org. Please Note: this e-mail address is only for reporting problems with ASF Bugzilla. Mail about any other subject will be silently ignored.

• • Home
  • | New
  • | Browse
  • | Search
  • |
    [?]
  • | Reports
  • | Help
  • | New Account
  • | Log In
    Remember [x]
  • | Forgot Password
    Login: [x]