Attachment 20778 Details for Bug 43323 – Add parent to constructor and createSpContainer

[patch] Add parent to constructor and createSpContainer

poi_pict_group.patch (text/plain), 1.31 KB, created by Danno Ferrin on 2007-09-06 13:36:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Danno Ferrin

Created: 2007-09-06 13:36:14 UTC

Size: 1.31 KB

patch

obsolete

>Index: src/scratchpad/src/org/apache/poi/hslf/model/Picture.java
>===================================================================
>--- src/scratchpad/src/org/apache/poi/hslf/model/Picture.java	(revision 569826)
>+++ src/scratchpad/src/org/apache/poi/hslf/model/Picture.java	(working copy)
>@@ -75,10 +75,14 @@
>     * @param idx the index of the picture
>      */
>     public Picture(int idx){
>-        super(null, null);
>-        _escherContainer = createSpContainer(idx);
>+        this(idx, null);
>     }
> 
>+    public Picture(int idx, Shape parent) {
>+        super(null, parent);
>+        _escherContainer = createSpContainer(idx, parent instanceof ShapeGroup);
>+    }
>+
>     /**
>       * Create a <code>Picture</code> object
>       *
>@@ -109,8 +113,8 @@
>      * @param idx the index of the picture which referes to <code>EscherBSE</code> container.
>      * @return the create Picture object
>      */
>-    protected EscherContainerRecord createSpContainer(int idx) {
>-        EscherContainerRecord spContainer = super.createSpContainer(false);
>+    protected EscherContainerRecord createSpContainer(int idx, boolean isChild) {
>+        EscherContainerRecord spContainer = super.createSpContainer(isChild);
>         spContainer.setOptions((short)15);
> 
>         EscherSpRecord spRecord = spContainer.getChildById(EscherSpRecord.RECORD_ID);

Actions: View | Diff

Attachments on bug 43323: 20778 | 20788