Attachment 20780 Details for Bug 43329 – patch for threadproc/win32/proc.c bug 43329

[patch] patch for threadproc/win32/proc.c bug 43329

apr129_createprocess_bug.patch (text/plain), 1.93 KB, created by Tom Donovan on 2007-09-07 12:20:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tom Donovan

Created: 2007-09-07 12:20:15 UTC

Size: 1.93 KB

patch

obsolete

>Index: threadproc/win32/proc.c
>===================================================================
>--- threadproc/win32/proc.c	(revision 573672)
>+++ threadproc/win32/proc.c	(working copy)
>@@ -769,15 +769,17 @@
>          */
>         EnterCriticalSection(&proc_lock);
> 
>+        si.hStdInput = si.hStdOutput = si.hStdError = INVALID_HANDLE_VALUE;
>+
>         if ((attr->child_in && attr->child_in->filehand)
>             || (attr->child_out && attr->child_out->filehand)
>             || (attr->child_err && attr->child_err->filehand))
>         {
>             si.dwFlags |= STARTF_USESTDHANDLES;
> 
>-            si.hStdInput = GetStdHandle(STD_INPUT_HANDLE);
>             if (attr->child_in && attr->child_in->filehand)
>             {
>+                si.hStdInput = GetStdHandle(STD_INPUT_HANDLE);
>                 if (GetHandleInformation(si.hStdInput,
>                                          &stdin_reset)
>                         && (stdin_reset &= HANDLE_FLAG_INHERIT))
>@@ -789,9 +791,9 @@
>                                                    HANDLE_FLAG_INHERIT);
>             }
>             
>-            si.hStdOutput = GetStdHandle(STD_OUTPUT_HANDLE);
>             if (attr->child_out && attr->child_out->filehand)
>             {
>+                si.hStdOutput = GetStdHandle(STD_OUTPUT_HANDLE);
>                 if (GetHandleInformation(si.hStdOutput,
>                                          &stdout_reset)
>                         && (stdout_reset &= HANDLE_FLAG_INHERIT))
>@@ -803,9 +805,9 @@
>                                                     HANDLE_FLAG_INHERIT);
>             }
> 
>-            si.hStdError = GetStdHandle(STD_ERROR_HANDLE);
>             if (attr->child_err && attr->child_err->filehand)
>             {
>+                si.hStdError = GetStdHandle(STD_ERROR_HANDLE);
>                 if (GetHandleInformation(si.hStdError,
>                                          &stderr_reset)
>                         && (stderr_reset &= HANDLE_FLAG_INHERIT))

Actions: View | Diff

Attachments on bug 43329: 20780 | 20782