[patch] Should fix memory leak when closing test plans

jmeter1.diff (text/plain), 3.01 KB, created by Jaroslav Bachorik on 2007-12-05 02:12:13 UTC

(hide)

Description: Should fix memory leak when closing test plans

Filename:

MIME Type:

Creator: Jaroslav Bachorik

Created: 2007-12-05 02:12:13 UTC

Size: 3.01 KB

patch

obsolete

># This patch file was generated by NetBeans IDE ># Following Index: paths are relative to: /home/jb198685/NetBeansProjects/jakarta-jmeter-src/src/core ># This patch can be applied using context Tools: Patch action on respective folder. ># It uses platform neutral UTF-8 encoding and \n newlines. ># Above lines and this line are ignored by the patching process. >Index: org/apache/jmeter/gui/GuiPackage.java >--- org/apache/jmeter/gui/GuiPackage.java Base (BASE) >+++ org/apache/jmeter/gui/GuiPackage.java Locally Modified (Based On LOCAL) >@@ -619,7 +619,18 @@ > return testPlanFile; > } > >+ public void clearTestPlan() { >+ getTreeModel().clearTestPlan(); >+ nodesToGui.clear(); >+ setTestPlanFile(null); >+ } > >+ public void clearTestPlan(TestElement element) { >+ getTreeModel().clearTestPlan(element); >+ removeNode(element); >+ } >+ >+ >\ No newline at end of file > public static void showErrorMessage(final String message, final String title){ > showMessage(message,title,JOptionPane.ERROR_MESSAGE); > } >Index: org/apache/jmeter/gui/action/Close.java >--- org/apache/jmeter/gui/action/Close.java Base (BASE) >+++ org/apache/jmeter/gui/action/Close.java Locally Modified (Based On LOCAL) >@@ -96,7 +96,7 @@ > static void closeProject(ActionEvent e) { > GuiPackage guiPackage = GuiPackage.getInstance(); > >- guiPackage.getTreeModel().clearTestPlan(); >+ guiPackage.clearTestPlan(); > guiPackage.getTreeListener().getJTree().setSelectionRow(1); > > // Clear the name of the test plan file >Index: org/apache/jmeter/gui/action/Load.java >--- org/apache/jmeter/gui/action/Load.java Base (BASE) >+++ org/apache/jmeter/gui/action/Load.java Locally Modified (Based On LOCAL) >@@ -146,7 +146,7 @@ > // If we are loading a new test plan, initialize the tree with the testplan node we are loading > GuiPackage guiInstance = GuiPackage.getInstance(); > if(isTestPlan && !merging) { >- guiInstance.getTreeModel().clearTestPlan((TestElement)tree.getArray()[0]); >+ guiInstance.clearTestPlan((TestElement)tree.getArray()[0]); > } > > if (merging){ // Check if target of merge is reasonable >Index: org/apache/jmeter/reporters/AbstractListenerElement.java >--- org/apache/jmeter/reporters/AbstractListenerElement.java Base (BASE) >+++ org/apache/jmeter/reporters/AbstractListenerElement.java Locally Modified (Based On LOCAL) >@@ -18,6 +18,7 @@ > > package org.apache.jmeter.reporters; > >+import java.lang.ref.WeakReference; > import org.apache.jmeter.testelement.AbstractTestElement; > import org.apache.jmeter.visualizers.Visualizer; > >@@ -27,17 +28,17 @@ > */ > > public abstract class AbstractListenerElement extends AbstractTestElement { >- transient private Visualizer listener; >+ transient private WeakReference listener; > > public AbstractListenerElement() { > } > > protected Visualizer getVisualizer() { >- return listener; >+ return (Visualizer)listener.get(); > } > > public void setListener(Visualizer vis) { >- listener = vis; >+ listener = new WeakReference(vis); > } > > public Object clone() { View Attachment As Diff View Attachment As Raw

This is ASF Bugzilla: the Apache Software Foundation bug system. In case of problems with the functioning of ASF Bugzilla, please contact bugzilla-admin@apache.org. Please Note: this e-mail address is only for reporting problems with ASF Bugzilla. Mail about any other subject will be silently ignored.

• • Home
  • | New
  • | Browse
  • | Search
  • |
    [?]
  • | Reports
  • | Help
  • | New Account
  • | Log In
    Remember [x]
  • | Forgot Password
    Login: [x]