ASF Bugzilla – Attachment 21789 Details for
Bug 30311
Conditional formatting not implemented
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Set some bits in FontFormatting record to match with Excel
patch7.txt (text/plain), 4.25 KB, created by
Dmitriy Kumshayev
on 2008-04-07 20:45:24 UTC
(
hide
)
Description:
Set some bits in FontFormatting record to match with Excel
Filename:
MIME Type:
Creator:
Dmitriy Kumshayev
Created:
2008-04-07 20:45:24 UTC
Size:
4.25 KB
patch
obsolete
>Index: C:/Documents and Settings/dq/workspace/poi/src/java/org/apache/poi/hssf/record/cf/FontFormatting.java >=================================================================== >--- C:/Documents and Settings/dq/workspace/poi/src/java/org/apache/poi/hssf/record/cf/FontFormatting.java (revision 645751) >+++ C:/Documents and Settings/dq/workspace/poi/src/java/org/apache/poi/hssf/record/cf/FontFormatting.java (working copy) >@@ -46,7 +46,9 @@ > private static final int OFFSET_ESCAPEMENT_TYPE_MODIFIED = 92; > private static final int OFFSET_UNDERLINE_TYPE_MODIFIED = 96; > private static final int OFFSET_FONT_WEIGHT_MODIFIED = 100; >- private static final int OFFSET_NOT_USED = 104; >+ private static final int OFFSET_NOT_USED1 = 104; >+ private static final int OFFSET_NOT_USED2 = 108; >+ private static final int OFFSET_NOT_USED3 = 112; // for some reason Excel always writes 0x7FFFFFFF at this offset > private static final int OFFSET_FONT_FORMATING_END = 116; > > >@@ -140,7 +142,9 @@ > this.setUnderlineTypeModified(false); > > LittleEndian.putShort(record, OFFSET_FONT_NAME, (short)0); >- LittleEndian.putInt(record, OFFSET_NOT_USED, 0x00000001); >+ LittleEndian.putInt(record, OFFSET_NOT_USED1, 0x00000001); >+ LittleEndian.putInt(record, OFFSET_NOT_USED2, 0x00000000); >+ LittleEndian.putInt(record, OFFSET_NOT_USED3, 0x7FFFFFFF);// for some reason Excel always writes 0x7FFFFFFF at this offset > LittleEndian.putShort(record, OFFSET_FONT_FORMATING_END, (short)0x0001); > } > >@@ -551,28 +555,6 @@ > } > buffer.append(" .color index = ").append("0x"+Integer.toHexString(getFontColorIndex()).toUpperCase()).append("\n"); > >- >- buffer.append(" ====\n"); >- buffer.append(" ["+OFFSET_FONT_HEIGHT+"] FONT HEIGHT: "+intToHex(OFFSET_FONT_HEIGHT)+"\n"); >- buffer.append(" ["+OFFSET_FONT_OPTIONS+"] FONT OPTIONS: "+intToHex(OFFSET_FONT_OPTIONS)+"\n"); >- buffer.append(" ["+OFFSET_FONT_WEIGHT+"] FONT WEIGHT: "+shortToHex(OFFSET_FONT_WEIGHT)+"\n"); >- buffer.append(" ["+OFFSET_ESCAPEMENT_TYPE+"] FONT ESCAPEMENT: "+shortToHex(OFFSET_ESCAPEMENT_TYPE)+"\n"); >- buffer.append(" ["+OFFSET_UNDERLINE_TYPE+"] FONT UNDERLINE: "+byteToHex(OFFSET_UNDERLINE_TYPE)+"\n"); >- buffer.append(" ["+(OFFSET_UNDERLINE_TYPE+1)+"] FONT NOT USED: "+byteToHex(OFFSET_UNDERLINE_TYPE+1)+"\n"); >- buffer.append(" ["+(OFFSET_UNDERLINE_TYPE+2)+"] FONT NOT USED: "+byteToHex(OFFSET_UNDERLINE_TYPE+2)+"\n"); >- buffer.append(" ["+(OFFSET_UNDERLINE_TYPE+3)+"] FONT NOT USED: "+byteToHex(OFFSET_UNDERLINE_TYPE+3)+"\n"); >- buffer.append(" ["+OFFSET_FONT_COLOR_INDEX+"] FONT COLIDX: "+intToHex(OFFSET_FONT_COLOR_INDEX)+"\n"); >- buffer.append(" ["+(OFFSET_FONT_COLOR_INDEX+4)+"] FONT NOT USED: "+intToHex(OFFSET_FONT_COLOR_INDEX+4)+"\n"); >- buffer.append(" ["+OFFSET_OPTION_FLAGS+"] FONT OPTIONS: "+intToHex(OFFSET_OPTION_FLAGS)+"\n"); >- buffer.append(" ["+OFFSET_ESCAPEMENT_TYPE_MODIFIED+"] FONT ESC MOD: "+intToHex(OFFSET_ESCAPEMENT_TYPE_MODIFIED)+"\n"); >- buffer.append(" ["+OFFSET_UNDERLINE_TYPE_MODIFIED+"] FONT UND MOD: "+intToHex(OFFSET_UNDERLINE_TYPE_MODIFIED)+"\n"); >- buffer.append(" ["+OFFSET_FONT_WEIGHT+"] FONT WGH MOD: "+intToHex(OFFSET_FONT_WEIGHT)+"\n"); >- buffer.append(" ["+OFFSET_NOT_USED+"] FONT NOT USED: "+intToHex(OFFSET_NOT_USED)+"\n"); >- buffer.append(" ["+(OFFSET_NOT_USED+4)+"] FONT NOT USED: "+intToHex(OFFSET_NOT_USED+4)+"\n"); >- buffer.append(" ["+(OFFSET_NOT_USED+8)+"] FONT NOT USED: "+intToHex(OFFSET_NOT_USED+8)+"\n"); >- buffer.append(" ["+OFFSET_FONT_FORMATING_END+"] FONT FORMATTING END: "+shortToHex(OFFSET_FONT_FORMATING_END)+"\n"); >- buffer.append(" ====\n"); >- > buffer.append(" [/Font Formatting]\n"); > return buffer.toString(); > } >@@ -589,17 +571,4 @@ > return rec; > } > >- private String intToHex(int offset) >- { >- return Integer.toHexString(LittleEndian.getInt(record, offset)); >- } >- private String shortToHex(int offset) >- { >- return Integer.toHexString(LittleEndian.getShort(record, offset)&0xFFFF); >- } >- private String byteToHex(int offset) >- { >- return Integer.toHexString(record[offset]&0xFF); >- } >- > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 30311
:
21680
|
21681
|
21708
|
21709
|
21711
|
21733
|
21784
| 21789 |
21818