Attachment 26022 Details for Bug 49884 – Patch to make some private fields final

[patch] Patch to make some private fields final

AsyncContextImpl_final.patch (text/plain), 1.77 KB, created by Sebb on 2010-09-13 12:13:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sebb

Created: 2010-09-13 12:13:42 UTC

Size: 1.77 KB

patch

obsolete

>Index: java/org/apache/catalina/core/AsyncContextImpl.java
>===================================================================
>--- java/org/apache/catalina/core/AsyncContextImpl.java	(revision 995572)
>+++ java/org/apache/catalina/core/AsyncContextImpl.java	(working copy)
>@@ -59,15 +59,15 @@
>     
>     private ServletRequest servletRequest = null;
>     private ServletResponse servletResponse = null;
>-    private List<AsyncListenerWrapper> listeners = new ArrayList<AsyncListenerWrapper>();
>+    private final List<AsyncListenerWrapper> listeners = new ArrayList<AsyncListenerWrapper>();
>     private boolean hasOriginalRequestAndResponse = true;
>     private volatile Runnable dispatch = null;
>     private Context context = null;
>-    private AtomicReference<AsyncState> state = new AtomicReference<AsyncState>(AsyncState.NOT_STARTED);
>+    private final AtomicReference<AsyncState> state = new AtomicReference<AsyncState>(AsyncState.NOT_STARTED);
>     private long timeout = -1;
>     private AsyncEvent event = null;
>     
>-    private Request request;
>+    private final Request request;
>     
>     public AsyncContextImpl(Request request) {
>         if (log.isDebugEnabled()) {
>@@ -476,8 +476,8 @@
>     
>     private static class RunnableWrapper implements Runnable {
> 
>-        private Runnable wrapped = null;
>-        private Context context = null;
>+        private final Runnable wrapped;
>+        private final Context context;
>         
>         public RunnableWrapper(Runnable wrapped, Context ctxt) {
>             this.wrapped = wrapped;
>@@ -519,7 +519,7 @@
> 
>     private static class PrivilegedSetTccl implements PrivilegedAction<Void> {
> 
>-        private ClassLoader cl;
>+        private final ClassLoader cl;
> 
>         PrivilegedSetTccl(ClassLoader cl) {
>             this.cl = cl;

Actions: View | Diff

Attachments on bug 49884: 25989 | 26022