ASF Bugzilla – Attachment 28017 Details for
Bug 52275
memory leak in proxy_ajp_handler
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
remove-potential-for-memory-leak-in-mod_proxy_ajp.patch
remove-potential-for-memory-leak-in-mod_proxy_ajp.patch (text/plain), 1.48 KB, created by
Naohiro Ooiwa
on 2011-12-02 04:31:15 UTC
(
hide
)
Description:
remove-potential-for-memory-leak-in-mod_proxy_ajp.patch
Filename:
MIME Type:
Creator:
Naohiro Ooiwa
Created:
2011-12-02 04:31:15 UTC
Size:
1.48 KB
patch
obsolete
>Index: modules/proxy/mod_proxy_ajp.c >=================================================================== >--- modules/proxy/mod_proxy_ajp.c (revision 1208972) >+++ modules/proxy/mod_proxy_ajp.c (working copy) >@@ -703,23 +703,12 @@ > &proxy_module); > > /* >- * Note: Memory pool allocation. >- * A downstream keepalive connection is always connected to the existence >- * (or not) of an upstream keepalive connection. If this is not done then >- * load balancing against multiple backend servers breaks (one backend >- * server ends up taking 100% of the load), and the risk is run of >- * downstream keepalive connections being kept open unnecessarily. This >- * keeps webservers busy and ties up resources. >- * >- * As a result, we allocate all sockets out of the upstream connection >- * pool, and when we want to reuse a socket, we check first whether the >- * connection ID of the current upstream connection is the same as that >- * of the connection when the socket was opened. >+ * Use a shorter-lived pool to reduce memory usage >+ * and avoid a memory leak > */ >- apr_pool_t *p = r->connection->pool; >- apr_uri_t *uri = apr_palloc(r->connection->pool, sizeof(*uri)); >+ apr_pool_t *p = r->pool; >+ apr_uri_t *uri = apr_palloc(p, sizeof(*uri)); > >- > if (strncasecmp(url, "ajp:", 4) != 0) { > ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, "declining URL %s", url); > return DECLINED;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 52275
: 28017