[patch] Move exception from findFormulaGroupForCell to linkSharedFormulaRecord

patch.txt (text/plain), 1.01 KB, created by David Roe on 2012-01-30 10:35:15 UTC

(hide)

Description: Move exception from findFormulaGroupForCell to linkSharedFormulaRecord

Filename:

MIME Type:

Creator: David Roe

Created: 2012-01-30 10:35:15 UTC

Size: 1.01 KB

patch

obsolete

>Index: SharedValueManager.java >=================================================================== >--- SharedValueManager.java (revision 1237590) >+++ SharedValueManager.java (working copy) >@@ -158,6 +158,10 @@ > */ > public SharedFormulaRecord linkSharedFormulaRecord(CellReference firstCell, FormulaRecordAggregate agg) { > SharedFormulaGroup result = findFormulaGroupForCell(firstCell); >+ if(null == result) { >+ // TODO - fix file "15228.xls" so it opens in Excel after rewriting with POI >+ throw new RuntimeException("Failed to find a matching shared formula record"); >+ } > result.add(agg); > return result.getSFR(); > } >@@ -170,10 +174,6 @@ > } > } > SharedFormulaGroup sfg = _groupsCache.get(getKeyForCache(cellRef)); >- if(null == sfg) { >- // TODO - fix file "15228.xls" so it opens in Excel after rewriting with POI >- throw new RuntimeException("Failed to find a matching shared formula record"); >- } > return sfg; > } > View Attachment As Diff View Attachment As Raw

This is ASF Bugzilla: the Apache Software Foundation bug system. In case of problems with the functioning of ASF Bugzilla, please contact bugzilla-admin@apache.org. Please Note: this e-mail address is only for reporting problems with ASF Bugzilla. Mail about any other subject will be silently ignored.

• • Home
  • | New
  • | Browse
  • | Search
  • |
    [?]
  • | Reports
  • | Help
  • | New Account
  • | Log In
    Remember [x]
  • | Forgot Password
    Login: [x]