ASF Bugzilla – Attachment 28711 Details for
Bug 53180
DefaultInstanceManager#populateAnnotationsCache - incomplete check is used when validating for a setter method
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch proposal
DefaultInstanceManager.java.patch (text/plain), 1.09 KB, created by
Violeta Georgieva
on 2012-05-02 20:27:25 UTC
(
hide
)
Description:
Patch proposal
Filename:
MIME Type:
Creator:
Violeta Georgieva
Created:
2012-05-02 20:27:25 UTC
Size:
1.09 KB
patch
obsolete
>Index: java/org/apache/catalina/core/DefaultInstanceManager.java >=================================================================== >--- java/org/apache/catalina/core/DefaultInstanceManager.java (revision 1333175) >+++ java/org/apache/catalina/core/DefaultInstanceManager.java (working copy) >@@ -342,7 +342,9 @@ > String methodName = method.getName(); > if (context != null) { > // Resource injection only if JNDI is enabled >- if (injections != null && methodName.startsWith("set") && methodName.length() > 3) { >+ if (injections != null && methodName.startsWith("set") && methodName.length() > 3 >+ && method.getParameterTypes().length == 1 >+ && method.getReturnType().getName().equals("void")) { > String fieldName = Character.toLowerCase(methodName.charAt(3)) + methodName.substring(4); > if (injections.containsKey(fieldName)) { > annotations.add(new AnnotationCacheEntry(
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 53180
: 28711