[patch] patch for findbugs

bug40676-findbugs.patch (text/plain), 2.41 KB, created by Luis Bernardo on 2012-06-15 11:42:58 UTC

(hide)

Description: patch for findbugs

Filename:

MIME Type:

Creator: Luis Bernardo

Created: 2012-06-15 11:42:58 UTC

Size: 2.41 KB

patch

obsolete

>Index: src/java/org/apache/fop/render/pdf/AbstractImageAdapter.java >=================================================================== >--- src/java/org/apache/fop/render/pdf/AbstractImageAdapter.java (revision 1350566) >+++ src/java/org/apache/fop/render/pdf/AbstractImageAdapter.java (working copy) >@@ -226,7 +226,7 @@ > if (hival > MAX_HIVAL) { > throw new UnsupportedOperationException("hival must not go beyond " + MAX_HIVAL); > } >- indexed.add(new Integer(hival)); >+ indexed.add(Integer.valueOf(hival)); > int[] palette = new int[c]; > icm.getRGBs(palette); > ByteArrayOutputStream baout = new ByteArrayOutputStream(); >@@ -263,7 +263,7 @@ > icm.getBlues(blues); > for (int i = 0; i < icm.getMapSize(); i++) { > if ((alphas[i] & 0xFF) == 0) { >- return new Integer(i); >+ return Integer.valueOf(i); > } > } > return null; >Index: findbugs-exclude.xml >=================================================================== >--- findbugs-exclude.xml (revision 1350545) >+++ findbugs-exclude.xml (working copy) >@@ -5162,4 +5162,41 @@ > <Method name="getNonEmptyLevels"/> > <Bug pattern="PZLA_PREFER_ZERO_LENGTH_ARRAYS"/> > </Match> >+ <Match> >+ <Class name="org.apache.fop.render.pdf.AbstractImageAdapter"/> >+ <Method name="populateXObjectDictionaryForIndexColorModel"/> >+ <Bug pattern="OS_OPEN_STREAM"/> >+ </Match> >+ <Match> >+ <Class name="org.apache.fop.render.pdf.ImageRawPNGAdapter"/> >+ <Or> >+ <Method name="outputContents"/> >+ <Method name="setup"/> >+ </Or> >+ <Or> >+ <Bug pattern="OS_OPEN_STREAM"/> >+ <Bug pattern="OS_OPEN_STREAM_EXCEPTION_PATH"/> >+ </Or> >+ </Match> >+ <Match> >+ <Class name="org.apache.fop.render.ps.ImageEncoderPNG"/> >+ <Method name="writeTo"/> >+ <Bug pattern="OS_OPEN_STREAM"/> >+ </Match> >+ <Match> >+ <Or> >+ <Class name="org.apache.fop.render.pdf.PDFImageHandlerRawPNG"/> >+ <Class name="org.apache.fop.render.ps.PSImageHandlerRawPNG"/> >+ </Or> >+ <Method name="getSupportedImageFlavors"/> >+ <Bug pattern="EI_EXPOSE_REP"/> >+ </Match> >+ <Match> >+ <Class name="org.apache.fop.render.ps.PSImageHandlerRawPNG"/> >+ <Or> >+ <Method name="handleImage"/> >+ <Method name="generateForm"/> >+ </Or> >+ <Bug pattern="BC_UNCONFIRMED_CAST"/> >+ </Match> > </FindBugsFilter> View Attachment As Diff View Attachment As Raw

This is ASF Bugzilla: the Apache Software Foundation bug system. In case of problems with the functioning of ASF Bugzilla, please contact bugzilla-admin@apache.org. Please Note: this e-mail address is only for reporting problems with ASF Bugzilla. Mail about any other subject will be silently ignored.

• • Home
  • | New
  • | Browse
  • | Search
  • |
    [?]
  • | Reports
  • | Help
  • | New Account
  • | Log In
    Remember [x]
  • | Forgot Password
    Login: [x]