[patch] Spawn faster under low process count

mod_fcgid_spawn_faster.patch (text/plain), 2.76 KB, created by Dominic Benson on 2012-08-14 21:44:46 UTC

(hide)

Description: Spawn faster under low process count

Filename:

MIME Type:

Creator: Dominic Benson

Created: 2012-08-14 21:44:46 UTC

Size: 2.76 KB

patch

obsolete

>diff -rupN mod_fcgid-2.3.7/modules/fcgid/fcgid_bridge.c mod_fcgid-2.3.7-new/modules/fcgid/fcgid_bridge.c >--- mod_fcgid-2.3.7/modules/fcgid/fcgid_bridge.c 2012-04-17 13:58:29.000000000 +0100 >+++ mod_fcgid-2.3.7-new/modules/fcgid/fcgid_bridge.c 2012-08-14 22:01:49.000000000 +0100 >@@ -368,9 +368,22 @@ handle_request(request_rec * r, int role > { > fcgid_command fcgi_request; > fcgid_bucket_ctx *bucket_ctx; >- int i, j, cond_status; >+ int i, j, cond_status, spawn_low_water, spawn_high_water, cur_busy_count; > const char *location = NULL; > >+ /* Number to spin up without sleeping; currently borrow the >+ min process per class count. Logically, this should probably >+ be somewhere in the range between min and max, possibly >+ directly configurable, but this is better than the (effectively) >+ hardwired value of 1 in place before. */ >+ spawn_low_water = fcgi_request.cmdopts.min_class_process_count; >+ >+ /* Point at which to back off creating new processes. This permits >+ waiting longer when we're genuinely busy, without wasting time >+ when load is in a more normal range. Again, for now this is the >+ max permissible; */ >+ spawn_high_water = fcgi_request.cmdopts.max_class_process_count; >+ > bucket_ctx = apr_pcalloc(r->pool, sizeof(*bucket_ctx)); > > bucket_ctx->ipc.request = r; >@@ -394,11 +407,23 @@ handle_request(request_rec * r, int role > if (bucket_ctx->procnode) > break; > >- /* Avoid sleeping the very first time through if there are no >+ /* Avoid sleeping the very first time through if there are few > busy processes; the problem is just that we haven't spawned >- anything yet, so waiting is pointless */ >- if (i > 0 || j > 0 || count_busy_processes(r, &fcgi_request)) { >- apr_sleep(apr_time_from_sec(1)); >+ enough yet, so waiting is pointless */ >+ cur_busy_count = count_busy_processes(r, &fcgi_request); >+ if (i > 0 || j > 0 || cur_busy_count > spawn_low_water) { >+ /* If under the high water mark, don't wait long. We should >+ have a decent chance of completing in progress requests >+ in 250ms (which is still quite a long time by modern >+ standards). If we're over the high water mark, sleep the >+ full second. That does indicate heavy load, so we should >+ be averse to spawning new processes. */ >+ if (cur_busy_count < spawn_high_water) { >+ apr_sleep(apr_time_from_msec(250)); >+ } >+ else { >+ apr_sleep(apr_time_from_sec(1)); >+ } > > bucket_ctx->procnode = apply_free_procnode(r, &fcgi_request); > if (bucket_ctx->procnode) View Attachment As Diff View Attachment As Raw

This is ASF Bugzilla: the Apache Software Foundation bug system. In case of problems with the functioning of ASF Bugzilla, please contact bugzilla-admin@apache.org. Please Note: this e-mail address is only for reporting problems with ASF Bugzilla. Mail about any other subject will be silently ignored.

• • Home
  • | New
  • | Browse
  • | Search
  • |
    [?]
  • | Reports
  • | Help
  • | New Account
  • | Log In
    Remember [x]
  • | Forgot Password
    Login: [x]