[patch] The patch to the HSSFCellStyle. Forgot to mention it will throw an IllegalArgumentException for an invalid rotaion in the setRotation call

rotation.patch (text/plain), 10.43 KB, created by Jason Height on 2002-09-05 10:50:46 UTC

(hide)

Description: The patch to the HSSFCellStyle. Forgot to mention it will throw an IllegalArgumentException for an invalid rotaion in the setRotation call

Filename:

MIME Type:

Creator: Jason Height

Created: 2002-09-05 10:50:46 UTC

Size: 10.43 KB

patch

obsolete

>? jakarta-poi/build/classes >? jakarta-poi/build/contrib >? jakarta-poi/build/docs >? jakarta-poi/build/examples >? jakarta-poi/build/jakarta-poi-1.8.0-dev-20020903.jar >? jakarta-poi/build/jakarta-poi-contrib-1.8.0-dev-20020903.jar >? jakarta-poi/build/jakarta-poi-examples-1.8.0-dev-20020903.jar >? jakarta-poi/build/jakarta-poi-scratchpad-1.8.0-dev-20020903.jar >? jakarta-poi/build/java >? jakarta-poi/build/scratchpad >? jakarta-poi/build/testcases >? jakarta-poi/build/work >? jakarta-poi/src/java/Test.java >? jakarta-poi/tools/cents/forrest.cent/legal >? jakarta-poi/tools/cents/forrest.cent/tasks.properties >? jakarta-poi/tools/cents/forrest.cent/xbuild.xml >? jakarta-poi/tools/cents/forrest.cent/conf/cocoon.xconf >? jakarta-poi/tools/cents/forrest.cent/conf/sitemap.xmap >? jakarta-poi/tools/cents/forrest.cent/lib/avalon-excalibur-4.1.jar >? jakarta-poi/tools/cents/forrest.cent/lib/avalon-framework-4.1.2.jar >? jakarta-poi/tools/cents/forrest.cent/lib/avalon-scratchpad-20020212.jar >? jakarta-poi/tools/cents/forrest.cent/lib/cocoon-scratchpad-part.jar >? jakarta-poi/tools/cents/forrest.cent/lib/cocoon.jar >? jakarta-poi/tools/cents/forrest.cent/lib/commons-collections-1.0.jar >? jakarta-poi/tools/cents/forrest.cent/lib/commons-httpclient-20011012.jar >? jakarta-poi/tools/cents/forrest.cent/lib/jakarta-regexp-1.2.jar >? jakarta-poi/tools/cents/forrest.cent/lib/logkit-1.0.1.jar >? jakarta-poi/tools/cents/forrest.cent/lib/resolver-20020130.jar >? jakarta-poi/tools/cents/forrest.cent/resources/library/xslt/changes2document.xsl >? jakarta-poi/tools/cents/forrest.cent/resources/library/xslt/copyover.xsl >? jakarta-poi/tools/cents/forrest.cent/resources/library/xslt/doclist.xsl >? jakarta-poi/tools/cents/forrest.cent/resources/library/xslt/doclist2document.xsl >? jakarta-poi/tools/cents/forrest.cent/resources/library/xslt/faq2document.xsl >? jakarta-poi/tools/cents/forrest.cent/resources/library/xslt/filterlinks.xsl >? jakarta-poi/tools/cents/forrest.cent/resources/library/xslt/todo2document.xsl >? jakarta-poi/tools/cents/forrest.cent/resources/resources/images >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/catalog >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/catalog.xcat >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/CatalogManager.properties >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/README >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/dtd/book-cocoon-v10.dtd >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/dtd/changes-v11.dtd >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/dtd/document-v11.dtd >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/dtd/faq-v11.dtd >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/dtd/javadoc-v04draft.dtd >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/dtd/project.dtd >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/dtd/specification-v11.dtd >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/dtd/todo-v11.dtd >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/dtd/xgump.dtd >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/entity/ISOdia.pen >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/entity/ISOgrk1.pen >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/entity/ISOlat1.pen >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/entity/ISOnum.pen >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/entity/ISOpub.pen >? jakarta-poi/tools/cents/forrest.cent/resources/resources/schema/entity/ISOtech.pen >? jakarta-poi/tools/cents/forrest.cent/resources/skins/avalon-site >? jakarta-poi/tools/cents/forrest.cent/resources/skins/basic >? jakarta-poi/tools/cents/forrest.cent/resources/skins/forrest-site >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site2 >? jakarta-poi/tools/cents/forrest.cent/resources/skins/xml-apache-site >? jakarta-poi/tools/cents/forrest.cent/resources/skins/jakarta-site/images/add.jpg >? jakarta-poi/tools/cents/forrest.cent/resources/skins/jakarta-site/images/ant_logo_medium.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/jakarta-site/images/built-with-cocoon.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/jakarta-site/images/favicon.ico >? jakarta-poi/tools/cents/forrest.cent/resources/skins/jakarta-site/images/krysalis-compatible.jpg >? jakarta-poi/tools/cents/forrest.cent/resources/skins/jakarta-site/images/note.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/jakarta-site/images/remove.jpg >? jakarta-poi/tools/cents/forrest.cent/resources/skins/jakarta-site/images/update.jpg >? jakarta-poi/tools/cents/forrest.cent/resources/skins/jakarta-site/images/void.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/jakarta-site/xslt/html/book2menu.xsl >? jakarta-poi/tools/cents/forrest.cent/resources/skins/jakarta-site/xslt/html/document2html.xsl >? jakarta-poi/tools/cents/forrest.cent/resources/skins/jakarta-site/xslt/html/site2xhtml.xsl >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/css/compact.css >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/css/main.css >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/css/ns4_toxins.css >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/css/print.css >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/add.jpg >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/ant_logo_medium.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/built-with-cocoon.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/favicon.ico >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/grn_alert.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/icon_alert.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/icon_alertsml.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/icon_confirmsml.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/icon_downarrow.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/icon_downarrow_off.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/icon_downarrow_on.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/icon_help.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/icon_infosml.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/icon_uparrow.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/icon_uparrow_off.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/icon_uparrow_on.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/krysalis-compatible.jpg >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/note.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/nw_min.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/remove.jpg >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/seperator.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/seperator2.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/seperator3.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/se_min.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/strich.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/sw_min.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/update.jpg >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/up_pointer.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/images/void.gif >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/xslt/html/book2menu.xsl >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/xslt/html/document2html.xsl >? jakarta-poi/tools/cents/forrest.cent/resources/skins/scarab-site/xslt/html/site2xhtml.xsl >? jakarta-poi/tools/cents/junit.cent/legal >? jakarta-poi/tools/cents/junit.cent/lib >? jakarta-poi/tools/cents/junit.cent/tasks.properties >? jakarta-poi/tools/cents/junit.cent/xbuild.xml >Index: jakarta-poi/src/java/org/apache/poi/hssf/usermodel/HSSFCellStyle.java >=================================================================== >RCS file: /home/cvspublic/jakarta-poi/src/java/org/apache/poi/hssf/usermodel/HSSFCellStyle.java,v >retrieving revision 1.10 >diff -u -w -r1.10 HSSFCellStyle.java >--- jakarta-poi/src/java/org/apache/poi/hssf/usermodel/HSSFCellStyle.java 4 Jul 2002 04:48:17 -0000 1.10 >+++ jakarta-poi/src/java/org/apache/poi/hssf/usermodel/HSSFCellStyle.java 5 Sep 2002 10:43:32 -0000 >@@ -68,6 +68,7 @@ > * @version 1.0-pre > * > * @author Andrew C. Oliver (acoliver at apache dot org) >+ * @author Jason Height (jheight at chariot dot net dot au) > * @see org.apache.poi.hssf.usermodel.HSSFWorkbook#createCellStyle() > * @see org.apache.poi.hssf.usermodel.HSSFWorkbook#getCellStyleAt(short) > * @see org.apache.poi.hssf.usermodel.HSSFCell#setCellStyle(HSSFCellStyle) >@@ -473,22 +474,34 @@ > > /** > * set the degree of rotation for the text in the cell >- * @param rotation degrees >+ * @param rotation degrees (between -90 and 90 degrees) > */ > > public void setRotation(short rotation) > { >+ if ((rotation < 0)&&(rotation >= -90)) { >+ //Take care of the funny 4th quadrant issue >+ //The 4th quadrant (-1 to -90) is stored as (91 to 180) >+ rotation = (short)(90 - rotation); >+ } >+ else if ((rotation < -90) ||(rotation > 90)) >+ //Do not allow an incorrect rotation to be set >+ throw new IllegalArgumentException("The rotation must be between -90 and 90 degrees"); > format.setRotation(rotation); > } > > /** > * get the degree of rotation for the text in the cell >- * @return rotation degrees >+ * @return rotation degrees (between -90 and 90 degrees) > */ > > public short getRotation() > { >- return format.getRotation(); >+ short rotation = format.getRotation(); >+ if (rotation > 90) >+ //This is actually the 4th quadrant >+ rotation = (short)(90-rotation); >+ return rotation; > } > View Attachment As Diff View Attachment As Raw

This is ASF Bugzilla: the Apache Software Foundation bug system. In case of problems with the functioning of ASF Bugzilla, please contact bugzilla-admin@apache.org. Please Note: this e-mail address is only for reporting problems with ASF Bugzilla. Mail about any other subject will be silently ignored.

• • Home
  • | New
  • | Browse
  • | Search
  • |
    [?]
  • | Reports
  • | Help
  • | New Account
  • | Log In
    Remember [x]
  • | Forgot Password
    Login: [x]