ASF Bugzilla – Attachment 29616 Details for
Bug 54179
Improper logging of large messages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
simple patch - to review, not to use
moddumpio.patch (text/plain), 1.55 KB, created by
Marek Wianecki
on 2012-11-21 10:36:40 UTC
(
hide
)
Description:
simple patch - to review, not to use
Filename:
MIME Type:
Creator:
Marek Wianecki
Created:
2012-11-21 10:36:40 UTC
Size:
1.55 KB
patch
obsolete
>*** mod_dumpio.c.bak 2012-11-20 17:56:07.000000000 +0100 >--- modules/debugging/mod_dumpio.c 2012-11-21 11:21:59.000000000 +0100 >*************** >*** 68,75 **** >--- 68,77 ---- > char xlatebuf[dumpio_MAX_STRING_LEN + 1]; > #endif > const char *buf; >+ const char *buffTMP; > apr_size_t nbytes; > apr_status_t rv = apr_bucket_read(b, &buf, &nbytes, APR_BLOCK_READ); >+ buffTMP = buf; > > if (rv == APR_SUCCESS) > { >*************** >*** 97,106 **** > * within ap_log_error, and introduce new vformatter %-escapes > * for escaping text, and for binary text (fixed len strings). > */ >! ap_log_cerror(APLOG_MARK, APLOG_TRACE7, 0, c, > "mod_dumpio: %s (%s-%s): %.*s", f->frec->name, > (APR_BUCKET_IS_METADATA(b)) ? "metadata" : "data", >! b->type->name, (int)logbytes, buf); > #endif > } > } else { >--- 99,109 ---- > * within ap_log_error, and introduce new vformatter %-escapes > * for escaping text, and for binary text (fixed len strings). > */ >! ap_log_cerror(APLOG_MARK, APLOG_TRACE7, 0, c, > "mod_dumpio: %s (%s-%s): %.*s", f->frec->name, > (APR_BUCKET_IS_METADATA(b)) ? "metadata" : "data", >! b->type->name, (int)logbytes, buffTMP); >! buffTMP = buffTMP + (int)logbytes; > #endif > } > } else {
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 54179
: 29616