[patch] remove TODOs with more tolerant parser

TestNonLoginAndBasicAuthenticator.diff (text/plain), 2.24 KB, created by Brian Burch on 2013-06-15 15:05:07 UTC

(hide)

Description: remove TODOs with more tolerant parser

Filename:

MIME Type:

Creator: Brian Burch

Created: 2013-06-15 15:05:07 UTC

Size: 2.24 KB

patch

obsolete

>Index: test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java >=================================================================== >--- test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java (revision 1493343) >+++ test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java (working copy) >@@ -216,38 +216,28 @@ > > /* > * This is the same as testAcceptProtectedBasic (above), except >- * using white space around the username credential. >- * >- * The request is rejected with 401 SC_UNAUTHORIZED status. >- * >- * TODO: RFC2617 does not define the separation syntax between the >- * auth-scheme and basic-credentials tokens. Tomcat should tolerate >- * any reasonable amount of white space and return SC_OK. >+ * using white space around the username credential. The request >+ * is accepted. > */ > @Test > public void testUserExtraSpace() throws Exception { > doTestBasic(CONTEXT_PATH_LOGIN + URI_PROTECTED, NO_CREDENTIALS, > NO_COOKIES, HttpServletResponse.SC_UNAUTHORIZED); > doTestBasic(CONTEXT_PATH_LOGIN + URI_PROTECTED, SPACED_USERNAME, >- NO_COOKIES, HttpServletResponse.SC_UNAUTHORIZED); >+ NO_COOKIES, HttpServletResponse.SC_OK); > } > > /* > * This is the same as testAcceptProtectedBasic (above), except >- * using white space around the password credential. >- * >- * The request is rejected with 401 SC_UNAUTHORIZED status. >- * >- * TODO: RFC2617 does not define the separation syntax between the >- * auth-scheme and basic-credentials tokens. Tomcat should tolerate >- * any reasonable amount of white space and return SC_OK. >+ * using white space around the password credential. The request >+ * is accepted. > */ > @Test > public void testPasswordExtraSpace() throws Exception { > doTestBasic(CONTEXT_PATH_LOGIN + URI_PROTECTED, NO_CREDENTIALS, > NO_COOKIES, HttpServletResponse.SC_UNAUTHORIZED); > doTestBasic(CONTEXT_PATH_LOGIN + URI_PROTECTED, SPACED_PASSWORD, >- NO_COOKIES, HttpServletResponse.SC_UNAUTHORIZED); >+ NO_COOKIES, HttpServletResponse.SC_OK); > } > > /* View Attachment As Diff View Attachment As Raw

This is ASF Bugzilla: the Apache Software Foundation bug system. In case of problems with the functioning of ASF Bugzilla, please contact bugzilla-admin@apache.org. Please Note: this e-mail address is only for reporting problems with ASF Bugzilla. Mail about any other subject will be silently ignored.

• • Home
  • | New
  • | Browse
  • | Search
  • |
    [?]
  • | Reports
  • | Help
  • | New Account
  • | Log In
    Remember [x]
  • | Forgot Password
    Login: [x]