Naive attempt at detecting incomplete backend response in mod_proxy

2.2.x-mod_proxy-incomplete-naive.patch (text/plain), 1.77 KB, created by Hannes Schmidt on 2013-09-14 01:32:07 UTC

(hide)

Description: Naive attempt at detecting incomplete backend response in mod_proxy

Filename:

MIME Type:

Creator: Hannes Schmidt

Created: 2013-09-14 01:32:07 UTC

Size: 1.77 KB

patch

obsolete

>From 7bd9dcba04fc4201adce7f3963fb4b621b60aed4 Mon Sep 17 00:00:00 2001 >From: Hannes Schmidt <hannes@ucsc.edu> >Date: Mon, 19 Aug 2013 15:18:49 -0700 >Subject: [PATCH] Naive approach. Works at omitting the 0-length chunk, but > probably breaks other things. > >--- > modules/http/http_filters.c | 3 +++ > modules/proxy/mod_proxy_http.c | 3 --- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/modules/http/http_filters.c b/modules/http/http_filters.c >index 1aed70b..16d363f 100644 >--- a/modules/http/http_filters.c >+++ b/modules/http/http_filters.c >@@ -494,6 +494,9 @@ apr_status_t ap_http_filter(ap_filter_t *f, apr_bucket_brigade *b, > (ctx->remaining < 0) ? "(overflow)" : ""); > ctx->remaining = 0; /* Reset it in case we have to > * come back here later */ >+ if (APR_STATUS_IS_EOF(rv)) { >+ return rv; >+ } > if (APR_STATUS_IS_TIMEUP(rv)) { > http_error = HTTP_REQUEST_TIME_OUT; > } >diff --git a/modules/proxy/mod_proxy_http.c b/modules/proxy/mod_proxy_http.c >index 072c24a..f1847a5 100644 >--- a/modules/proxy/mod_proxy_http.c >+++ b/modules/proxy/mod_proxy_http.c >@@ -1788,9 +1788,6 @@ apr_status_t ap_proxy_http_process_response(apr_pool_t * p, request_rec *r, > mode = APR_BLOCK_READ; > continue; > } >- else if (rv == APR_EOF) { >- break; >- } > else if (rv != APR_SUCCESS) { > /* In this case, we are in real trouble because > * our backend bailed on us. Pass along a 502 error >-- >1.7.11.1 > View Attachment As Raw

This is ASF Bugzilla: the Apache Software Foundation bug system. In case of problems with the functioning of ASF Bugzilla, please contact bugzilla-admin@apache.org. Please Note: this e-mail address is only for reporting problems with ASF Bugzilla. Mail about any other subject will be silently ignored.

• • Home
  • | New
  • | Browse
  • | Search
  • |
    [?]
  • | Reports
  • | Help
  • | New Account
  • | Log In
    Remember [x]
  • | Forgot Password
    Login: [x]