View | Details | Raw Unified | Return to bug 55410
Collapse All | Expand All

(-)file_not_specified_in_diff (-3 / +4 lines)
Line  Link Here
0
-- a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFVMLDrawing.java
0
++ b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFVMLDrawing.java
Lines 68-73 public final class XSSFVMLDrawing extends POIXMLDocumentPart { Link Here
68
    private static final QName QNAME_SHAPE_LAYOUT = new QName("urn:schemas-microsoft-com:office:office", "shapelayout");
68
    private static final QName QNAME_SHAPE_LAYOUT = new QName("urn:schemas-microsoft-com:office:office", "shapelayout");
69
    private static final QName QNAME_SHAPE_TYPE = new QName("urn:schemas-microsoft-com:vml", "shapetype");
69
    private static final QName QNAME_SHAPE_TYPE = new QName("urn:schemas-microsoft-com:vml", "shapetype");
70
    private static final QName QNAME_SHAPE = new QName("urn:schemas-microsoft-com:vml", "shape");
70
    private static final QName QNAME_SHAPE = new QName("urn:schemas-microsoft-com:vml", "shape");
71
    private static final String COMMENT_SHAPE_TYPE_ID = "_x0000_t202"; // this ID value seems to have significance to Excel >= 2010; see https://issues.apache.org/bugzilla/show_bug.cgi?id=55409
71
72
72
    /**
73
    /**
73
     * regexp to parse shape ids, in VML they have weird form of id="_x0000_s1026"
74
     * regexp to parse shape ids, in VML they have weird form of id="_x0000_s1026"
Lines 190-196 public final class XSSFVMLDrawing extends POIXMLDocumentPart { Link Here
190
        _qnames.add(QNAME_SHAPE_LAYOUT);
191
        _qnames.add(QNAME_SHAPE_LAYOUT);
191
192
192
        CTShapetype shapetype = CTShapetype.Factory.newInstance();
193
        CTShapetype shapetype = CTShapetype.Factory.newInstance();
193
        _shapeTypeId = "_xssf_cell_comment";
194
        _shapeTypeId = COMMENT_SHAPE_TYPE_ID;
194
        shapetype.setId(_shapeTypeId);
195
        shapetype.setId(_shapeTypeId);
195
        shapetype.setCoordsize("21600,21600");
196
        shapetype.setCoordsize("21600,21600");
196
        shapetype.setSpt(202);
197
        shapetype.setSpt(202);
Lines 258-261 public final class XSSFVMLDrawing extends POIXMLDocumentPart { Link Here
258
        CTShape shape = findCommentShape(row, col);
259
        CTShape shape = findCommentShape(row, col);
259
        return shape != null && _items.remove(shape);
260
        return shape != null && _items.remove(shape);
260
    }
261
    }
261
}
262
}

Return to bug 55410