ASF Bugzilla – Attachment 31905 Details for
Bug 56835
[PATCH] Unreadable content when adding multiple comments to cell
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
patch
XSSFDrawing.java.patch (text/plain), 1.16 KB, created by
Javen O'Neal
on 2014-08-12 01:40:18 UTC
(
hide
)
Description:
patch
Filename:
MIME Type:
Creator:
Javen O'Neal
Created:
2014-08-12 01:40:18 UTC
Size:
1.16 KB
patch
obsolete
>Index: XSSFDrawing.java >=================================================================== >--- XSSFDrawing.java (revision 1617386) >+++ XSSFDrawing.java (working copy) >@@ -284,6 +284,7 @@ > * @param anchor the client anchor describes how this comment is attached > * to the sheet. > * @return the newly created comment. >+ * @throws IllegalArgumentException if comment already exists in cell at (anchor.getRow1(), anchor.getCol1()) > */ > public XSSFComment createCellComment(ClientAnchor anchor) { > XSSFClientAnchor ca = (XSSFClientAnchor)anchor; >@@ -300,7 +301,12 @@ > vmlShape.getClientDataArray(0).setAnchorArray(0, position); > } > String ref = new CellReference(ca.getRow1(), ca.getCol1()).formatAsString(); >- XSSFComment shape = new XSSFComment(comments, comments.newComment(ref), vmlShape); >+ if(comments.findCellComment(ref) == null) { >+ XSSFComment shape = new XSSFComment(comments, comments.newComment(ref), vmlShape); >+ } >+ else { >+ throw new IllegalArgumentException("Multiple cell comments not allowed in the same cell."); >+ } > return shape; > } >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 56835
:
31904
| 31905