ASF Bugzilla – Attachment 31919 Details for
Bug 56858
non-terminated buffer passed to ap_log_rerror
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
stderr-terminate-buffer.patch
mod_proxy_fcgi-stderr-terminate-buffer.patch (text/plain), 726 bytes, created by
Manuel Mausz
on 2014-08-15 00:54:55 UTC
(
hide
)
Description:
stderr-terminate-buffer.patch
Filename:
MIME Type:
Creator:
Manuel Mausz
Created:
2014-08-15 00:54:55 UTC
Size:
726 bytes
patch
obsolete
>diff --git a/modules/proxy/mod_proxy_fcgi.c b/modules/proxy/mod_proxy_fcgi.c >index d7ab5cb..b655a76 100644 >--- a/modules/proxy/mod_proxy_fcgi.c >+++ b/modules/proxy/mod_proxy_fcgi.c >@@ -664,8 +664,10 @@ recv_again: > case AP_FCGI_STDERR: > /* TODO: Should probably clean up this logging a bit... */ > if (clen) { >+ char c = iobuf[readbuflen - 1]; >+ iobuf[readbuflen - 1] = '\0'; > ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO(01071) >- "Got error '%s'", iobuf); >+ "Got error '%s%c'", iobuf, c); > } > > if (clen > readbuflen) {
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 56858
: 31919