Attachment 32118 Details for Bug 57101 – Patch that improves error reporting

[patch] Patch that improves error reporting

mod_fcgid-2.3.9-verbose_spawn.patch (text/plain), 2.89 KB, created by lluismh on 2014-10-16 20:48:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: lluismh

Created: 2014-10-16 20:48:03 UTC

Size: 2.89 KB

patch

obsolete

>diff -rupN mod_fcgid-2.3.9/modules/fcgid/fcgid_proc_unix.c mod_fcgid-2.3.9-verbose_spawn/modules/fcgid/fcgid_proc_unix.c
>--- mod_fcgid-2.3.9/modules/fcgid/fcgid_proc_unix.c	2013-07-06 14:44:24.000000000 -0400
>+++ mod_fcgid-2.3.9-verbose_spawn/modules/fcgid/fcgid_proc_unix.c	2014-10-16 16:15:51.327220061 -0400
>@@ -357,6 +357,7 @@ apr_status_t proc_spawn_process(const ch
>         || (rv = apr_procattr_cmdtype_set(procattr, APR_PROGRAM)) != APR_SUCCESS
>         || (rv = apr_os_file_put(&file, &unix_socket, 0,
>                                  procnode->proc_pool)) != APR_SUCCESS
>+        || (rv = apr_procattr_child_errfn_set(procattr, fcgid_errfn)) != APR_SUCCESS
>         || (rv = apr_procattr_child_in_set(procattr, file, NULL)) != APR_SUCCESS) {
>         ap_log_error(APLOG_MARK, APLOG_ERR, rv, procinfo->main_server,
>                      "mod_fcgid: couldn't set child process attributes: %s",
>diff -rupN mod_fcgid-2.3.9/modules/fcgid/fcgid_proc_win.c mod_fcgid-2.3.9-verbose_spawn/modules/fcgid/fcgid_proc_win.c
>--- mod_fcgid-2.3.9/modules/fcgid/fcgid_proc_win.c	2012-11-16 13:33:14.000000000 -0500
>+++ mod_fcgid-2.3.9-verbose_spawn/modules/fcgid/fcgid_proc_win.c	2014-10-16 16:26:39.583001210 -0400
>@@ -146,6 +146,7 @@ apr_status_t proc_spawn_process(const ch
>                                      APR_NO_FILE, APR_NO_FILE)) != APR_SUCCESS
>         || (rv = apr_os_file_put(&file, &listen_handle, 0,
>                                  procnode->proc_pool)) != APR_SUCCESS
>+        || (rv = apr_procattr_child_errfn_set(proc_attr, fcgid_errfn)) != APR_SUCCESS
>         || (rv = apr_procattr_child_in_set(proc_attr, file, NULL))
>                != APR_SUCCESS)
>     {
>diff -rupN mod_fcgid-2.3.9/modules/fcgid/fcgid_spawn_ctl.c mod_fcgid-2.3.9-verbose_spawn/modules/fcgid/fcgid_spawn_ctl.c
>--- mod_fcgid-2.3.9/modules/fcgid/fcgid_spawn_ctl.c	2012-03-01 17:15:19.000000000 -0500
>+++ mod_fcgid-2.3.9-verbose_spawn/modules/fcgid/fcgid_spawn_ctl.c	2014-10-16 16:32:14.253970345 -0400
>@@ -251,3 +251,9 @@ int is_kill_allowed(server_rec * main_se
> 
>     return 1;
> }
>+
>+void fcgid_errfn (apr_pool_t *p, apr_status_t err, const char *description)
>+{
>+    ap_log_error(APLOG_MARK, APLOG_ERR, err, NULL,
>+                "mod_fcgid: error spawning process: %s", description);
>+}
>diff -rupN mod_fcgid-2.3.9/modules/fcgid/fcgid_spawn_ctl.h mod_fcgid-2.3.9-verbose_spawn/modules/fcgid/fcgid_spawn_ctl.h
>--- mod_fcgid-2.3.9/modules/fcgid/fcgid_spawn_ctl.h	2009-09-17 09:56:23.000000000 -0400
>+++ mod_fcgid-2.3.9-verbose_spawn/modules/fcgid/fcgid_spawn_ctl.h	2014-10-16 16:15:39.281970009 -0400
>@@ -26,5 +26,6 @@ void register_termination(server_rec * m
> void register_spawn(server_rec * main_server, fcgid_procnode * procnode);
> int is_spawn_allowed(server_rec * main_server, fcgid_command * command);
> int is_kill_allowed(server_rec * main_server, fcgid_procnode * procnode);
>+void fcgid_errfn (apr_pool_t *p, apr_status_t err, const char *description);
> 
> #endif

Actions: View | Diff

Attachments on bug 57101: 32118