Attachment 32150 Details for Bug 57151 – The patch (generated from SVN on the current revision)

The patch (generated from SVN on the current revision)

CellRangeAddress.java.patch (text/plain), 1.34 KB, created by Viliam Anirud on 2014-10-27 12:58:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Viliam Anirud

Created: 2014-10-27 12:58:01 UTC

Size: 1.34 KB

patch

obsolete

>Index: src/java/org/apache/poi/ss/util/CellRangeAddress.java
>===================================================================
>--- src/java/org/apache/poi/ss/util/CellRangeAddress.java	(revision 1634512)
>+++ src/java/org/apache/poi/ss/util/CellRangeAddress.java	(working copy)
>@@ -17,9 +17,9 @@
> 
> package org.apache.poi.ss.util;
> 
>-import org.apache.poi.ss.formula.SheetNameFormatter;
> import org.apache.poi.hssf.record.RecordInputStream;
> import org.apache.poi.hssf.record.SelectionRecord;
>+import org.apache.poi.ss.formula.SheetNameFormatter;
> import org.apache.poi.util.LittleEndianByteArrayOutputStream;
> import org.apache.poi.util.LittleEndianOutput;
> 
>@@ -38,8 +38,19 @@
> 	 */
> 	public static final int ENCODED_SIZE = 8;
> 
>+	/**
>+	 * Creates new cell range. Indexes are zero-based.
>+	 * 
>+	 * @param firstRow Index of first row
>+	 * @param lastRow Index of last row (inclusive), must be equal to or larger than {@code firstRow}
>+	 * @param firstCol Index of first column
>+	 * @param lastCol Index of last column (inclusive), must be equal to or larger than {@code firstCol}
>+	 */
> 	public CellRangeAddress(int firstRow, int lastRow, int firstCol, int lastCol) {
> 		super(firstRow, lastRow, firstCol, lastCol);
>+		
>+		if (lastRow < firstRow || lastCol < firstCol)
>+		    throw new IllegalArgumentException("lastRow < firstRow || lastCol < firstCol");
> 	}
> 
> 	/**

Actions: View

Attachments on bug 57151: 32150