ASF Bugzilla – Attachment 32241 Details for
Bug 56546
Improve thread trace logging in WebappClassLoader.clearReferencesThreads()
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Diff file fort to list all stack traces before clearing threads
fix-56546.diff (text/plain), 1.66 KB, created by
Ahmed Hosny
on 2014-11-30 22:14:12 UTC
(
hide
)
Description:
Diff file fort to list all stack traces before clearing threads
Filename:
MIME Type:
Creator:
Ahmed Hosny
Created:
2014-11-30 22:14:12 UTC
Size:
1.66 KB
patch
obsolete
>Index: WebappClassLoaderBase.java >=================================================================== >--- WebappClassLoaderBase.java (revision 1642607) >+++ WebappClassLoaderBase.java (working copy) >@@ -1767,6 +1767,19 @@ > Thread[] threads = getThreads(); > List<Thread> executorThreadsToStop = new ArrayList<>(); > >+ // Log request thread data >+ for(Thread thread: threads){ >+ if(isRequestThread(thread)) { >+ log.warn(sm.getString("webappClassLoader.stackTraceRequestThread", >+ getContextName(), thread.getName(), getStackTrace(thread))); >+ } else { >+ log.warn(sm.getString("webappClassLoader.stackTrace", >+ getContextName(), thread.getName(), getStackTrace(thread))); >+ } >+ >+ >+ } >+ > // Iterate over the set of threads > for (Thread thread : threads) { > if (thread != null) { >@@ -1810,14 +1823,7 @@ > continue; > } > >- if (isRequestThread(thread)) { >- log.warn(sm.getString("webappClassLoader.stackTraceRequestThread", >- getContextName(), threadName, getStackTrace(thread))); >- } else { >- log.warn(sm.getString("webappClassLoader.stackTrace", >- getContextName(), threadName, getStackTrace(thread))); >- } >- >+ > // Don't try an stop the threads unless explicitly > // configured to do so > if (!clearReferencesStopThreads) {
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 56546
: 32241