ASF Bugzilla – Attachment 32645 Details for
Bug 46412
make_child return value not checked
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
checking return value of make_child()
httpd-46412-make_child-2.patch (text/plain), 2.13 KB, created by
thekevinday
on 2015-04-13 16:50:50 UTC
(
hide
)
Description:
checking return value of make_child()
Filename:
MIME Type:
Creator:
thekevinday
Created:
2015-04-13 16:50:50 UTC
Size:
2.13 KB
patch
obsolete
>Index: server/mpm/event/event.c >=================================================================== >--- server/mpm/event/event.c (revision 1673237) >+++ server/mpm/event/event.c (working copy) >@@ -2698,8 +2698,9 @@ > /* we're still doing a 1-for-1 replacement of dead > * children with new children > */ >- make_child(ap_server_conf, child_slot); >- --remaining_children_to_start; >+ if (make_child(ap_server_conf, child_slot) >= 0) { >+ --remaining_children_to_start; >+ } > } > } > else if (ap_unregister_extra_mpm_process(pid.pid, &old_gen) == 1) { >Index: server/mpm/prefork/prefork.c >=================================================================== >--- server/mpm/prefork/prefork.c (revision 1673237) >+++ server/mpm/prefork/prefork.c (working copy) >@@ -1048,8 +1048,9 @@ > /* we're still doing a 1-for-1 replacement of dead > * children with new children > */ >- make_child(ap_server_conf, child_slot); >- --remaining_children_to_start; >+ if (make_child(ap_server_conf, child_slot) >= 0) { >+ --remaining_children_to_start; >+ } > } > #if APR_HAS_OTHER_CHILD > } >Index: server/mpm/worker/worker.c >=================================================================== >--- server/mpm/worker/worker.c (revision 1673237) >+++ server/mpm/worker/worker.c (working copy) >@@ -1709,8 +1709,9 @@ > /* we're still doing a 1-for-1 replacement of dead > * children with new children > */ >- make_child(ap_server_conf, child_slot); >- --remaining_children_to_start; >+ if (make_child(ap_server_conf, child_slot) >= 0) { >+ --remaining_children_to_start; >+ } > } > } > else if (ap_unregister_extra_mpm_process(pid.pid, &old_gen) == 1) {
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 46412
:
23036
| 32645