[patch] throws IllegalArgumentException patch

CellFormatResult.java throws IllegalArgumentException.patch (text/plain), 2.98 KB, created by Javen O'Neal on 2015-08-18 18:38:31 UTC

(hide)

Description: throws IllegalArgumentException patch

Filename:

MIME Type:

Creator: Javen O'Neal

Created: 2015-08-18 18:38:31 UTC

Size: 2.98 KB

patch

obsolete

>Index: src/testcases/org/apache/poi/ss/format/TestCellFormatResult.java >=================================================================== >--- src/testcases/org/apache/poi/ss/format/TestCellFormatResult.java (revision 0) >+++ src/testcases/org/apache/poi/ss/format/TestCellFormatResult.java (revision 0) >@@ -0,0 +1,37 @@ >+/* ==================================================================== >+ Licensed to the Apache Software Foundation (ASF) under one or more >+ contributor license agreements. See the NOTICE file distributed with >+ this work for additional information regarding copyright ownership. >+ The ASF licenses this file to You under the Apache License, Version 2.0 >+ (the "License"); you may not use this file except in compliance with >+ the License. You may obtain a copy of the License at >+ >+ http://www.apache.org/licenses/LICENSE-2.0 >+ >+ Unless required by applicable law or agreed to in writing, software >+ distributed under the License is distributed on an "AS IS" BASIS, >+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. >+ See the License for the specific language governing permissions and >+ limitations under the License. >+==================================================================== */ >+package org.apache.poi.ss.format; >+ >+import java.awt.Color; >+ >+import junit.framework.TestCase; >+ >+public class TestCellFormatResult extends TestCase { >+ >+ public void testNullTextRaisesException() { >+ try { >+ final boolean applies = true; >+ final String text = null; >+ final Color textColor = Color.BLACK; >+ final CellFormatResult result = new CellFormatResult(applies, text, textColor); >+ fail("Cannot initialize CellFormatResult with null text parameter"); >+ } >+ catch (IllegalArgumentException e) { >+ //Expected >+ } >+ } >+} >\ No newline at end of file >Index: src/java/org/apache/poi/ss/format/CellFormatResult.java >=================================================================== >--- src/java/org/apache/poi/ss/format/CellFormatResult.java (revision 1696356) >+++ src/java/org/apache/poi/ss/format/CellFormatResult.java (working copy) >@@ -16,7 +16,7 @@ > ==================================================================== */ > package org.apache.poi.ss.format; > >-import java.awt.*; >+import java.awt.Color; > > /** > * This object contains the result of applying a cell format or cell format part >@@ -50,8 +50,10 @@ > * @param text The value for {@link #text}. > * @param textColor The value for {@link #textColor}. > */ >- public CellFormatResult(boolean applies, String text, Color textColor) { >+ public CellFormatResult(boolean applies, String text, Color textColor) throws IllegalArgumentException { > this.applies = applies; >+ if (text == null) >+ throw new IllegalArgumentException("CellFormatResult text may not be null"); > this.text = text; > this.textColor = (applies ? textColor : null); > } View Attachment As Diff View Attachment As Raw

This is ASF Bugzilla: the Apache Software Foundation bug system. In case of problems with the functioning of ASF Bugzilla, please contact bugzilla-admin@apache.org. Please Note: this e-mail address is only for reporting problems with ASF Bugzilla. Mail about any other subject will be silently ignored.

• • Home
  • | New
  • | Browse
  • | Search
  • |
    [?]
  • | Reports
  • | Help
  • | New Account
  • | Log In
    Remember [x]
  • | Forgot Password
    Login: [x]