Attachment 33089 Details for Bug 58353 – Patch for fixing bug with match function

[patch] Patch for fixing bug with match function

fix_match_function.patch (text/plain), 1.51 KB, created by Sergiy Nechyporchuk on 2015-09-10 11:58:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sergiy Nechyporchuk

Created: 2015-09-10 11:58:09 UTC

Size: 1.51 KB

patch

obsolete

>Index: src/testcases/org/apache/poi/ss/formula/functions/TestMatch.java
>IDEA additional info:
>Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
><+>UTF-8
>===================================================================
>--- src/testcases/org/apache/poi/ss/formula/functions/TestMatch.java	(revision 8456866d309da18eac5eb8127d405234c0527e06)
>+++ src/testcases/org/apache/poi/ss/formula/functions/TestMatch.java	(revision )
>@@ -89,6 +89,7 @@
> 		confirmInt(2, invokeMatch(new NumberEval(10), ae, MATCH_EXACT));
> 		confirmInt(4, invokeMatch(new NumberEval(9), ae, MATCH_SMALLEST_GTE));
> 		confirmInt(1, invokeMatch(new NumberEval(20), ae, MATCH_SMALLEST_GTE));
>+		confirmInt(5, invokeMatch(new NumberEval(3), ae, MATCH_SMALLEST_GTE));
> 		assertEquals(ErrorEval.NA, invokeMatch(new NumberEval(20), ae, MATCH_EXACT));
> 		assertEquals(ErrorEval.NA, invokeMatch(new NumberEval(26), ae, MATCH_SMALLEST_GTE));
> 	}
>Index: src/java/org/apache/poi/ss/formula/functions/Match.java
>IDEA additional info:
>Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
><+>UTF-8
>===================================================================
>--- src/java/org/apache/poi/ss/formula/functions/Match.java	(revision 8456866d309da18eac5eb8127d405234c0527e06)
>+++ src/java/org/apache/poi/ss/formula/functions/Match.java	(revision )
>@@ -228,8 +228,7 @@
> 				return i-1;
> 			}
> 		}
>-
>-		throw new EvaluationException(ErrorEval.NA);
>+		return size-1;
> 	}
> 
> 	private static LookupValueComparer createLookupComparer(ValueEval lookupValue, boolean matchExact) {

Actions: View | Diff

Attachments on bug 58353: 33089