Attachment 33124 Details for Bug 58441 – CellRangeAddressBase with added equals and hashCode methods

[patch] CellRangeAddressBase with added equals and hashCode methods

CellRangeAddressBase.java.equals.patch (text/plain), 1.34 KB, created by Javen O'Neal on 2015-09-21 21:25:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Javen O'Neal

Created: 2015-09-21 21:25:41 UTC

Size: 1.34 KB

patch

obsolete

>Index: src/java/org/apache/poi/ss/util/CellRangeAddressBase.java
>===================================================================
>--- src/java/org/apache/poi/ss/util/CellRangeAddressBase.java	(revision 1704412)
>+++ src/java/org/apache/poi/ss/util/CellRangeAddressBase.java	(working copy)
>@@ -164,4 +164,36 @@
> 		CellReference crB = new CellReference(_lastRow, _lastCol);
> 		return getClass().getName() + " [" + crA.formatAsString() + ":" + crB.formatAsString() +"]";
> 	}
>+	
>+	// In case _firstRow > _lastRow or _firstCol > _lastCol
>+	protected int getMinRow() {
>+		return Math.min(_firstRow, _lastRow);
>+	}
>+	protected int getMaxRow() {
>+		return Math.max(_firstRow, _lastRow);
>+	}
>+	protected int getMinColumn() {
>+		return Math.min(_firstCol, _lastCol);
>+	}
>+	protected int getMaxColumn() {
>+		return Math.max(_firstCol, _lastCol);
>+	}
>+	
>+	@Override
>+	public boolean equals(Object other) {
>+		if (other instanceof CellRangeAddressBase) {
>+			CellRangeAddressBase o = (CellRangeAddressBase) other;
>+			return ((getMinRow() == o.getMinRow()) &&
>+					(getMaxRow() == o.getMaxRow()) &&
>+					(getMinColumn() == o.getMinColumn()) &&
>+					(getMaxColumn() == o.getMaxColumn()));
>+		}
>+		return false;
>+	}
>+	
>+	@Override
>+	public int hashCode() {
>+		final int[] values = new int[]{getMinRow(), getMaxRow(), getMinColumn(), getMaxColumn()};
>+		return values.hashCode();
>+	}
> }

Actions: View | Diff

Attachments on bug 58441: 33124 | 33125