[patch] canComputeColumnWidht.patch

canComputeColumnWidht.patch (text/plain), 3.95 KB, created by Javen O'Neal on 2015-11-03 07:21:59 UTC

(hide)

Description: canComputeColumnWidht.patch

Filename:

MIME Type:

Creator: Javen O'Neal

Created: 2015-11-03 07:21:59 UTC

Size: 3.95 KB

patch

obsolete

>Index: src/java/org/apache/poi/ss/util/SheetUtil.java >=================================================================== >--- src/java/org/apache/poi/ss/util/SheetUtil.java (revision 1712217) >+++ src/java/org/apache/poi/ss/util/SheetUtil.java (working copy) >@@ -275,7 +275,7 @@ > * @param font The Font that is used in the Cell > * @return true if computing the size for this Font will succeed, false otherwise > */ >- public static boolean canComputeColumnWidht(Font font) { >+ public static boolean canComputeColumnWidth(Font font) { > // not sure what is the best value sample-here, only "1" did not work on some platforms... > AttributedString str = new AttributedString("1w"); > copyAttributes(font, str, 0, "1w".length()); >Index: src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFont.java >=================================================================== >--- src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFont.java (revision 1712217) >+++ src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFont.java (working copy) >@@ -299,7 +299,7 @@ > Workbook wb = new XSSFWorkbook(); > > // cannot check on result because on some machines we get back false here! >- SheetUtil.canComputeColumnWidht(wb.getFontAt((short)0)); >+ SheetUtil.canComputeColumnWidth(wb.getFontAt((short)0)); > > wb.close(); > } >@@ -310,6 +310,6 @@ > font.setFontName("some non existing font name"); > > // Even with invalid fonts we still get back useful data most of the time... >- SheetUtil.canComputeColumnWidht(font); >+ SheetUtil.canComputeColumnWidth(font); > } > } >Index: src/testcases/org/apache/poi/ss/usermodel/BaseTestBugzillaIssues.java >=================================================================== >--- src/testcases/org/apache/poi/ss/usermodel/BaseTestBugzillaIssues.java (revision 1712217) >+++ src/testcases/org/apache/poi/ss/usermodel/BaseTestBugzillaIssues.java (working copy) >@@ -381,7 +381,7 @@ > // autoSize will fail if required fonts are not installed, skip this test then > Font font = wb.getFontAt(cell0.getCellStyle().getFontIndex()); > Assume.assumeTrue("Cannot verify autoSizeColumn() because the necessary Fonts are not installed on this machine: " + font, >- SheetUtil.canComputeColumnWidht(font)); >+ SheetUtil.canComputeColumnWidth(font)); > > assertEquals("Expecting no indentation in this test", > 0, cell0.getCellStyle().getIndention()); >@@ -399,7 +399,7 @@ > double widthBeforeCol = SheetUtil.getColumnWidth(sheet, 0, false); > > String info = widthManual + "/" + widthBeforeCell + "/" + widthBeforeCol + "/" + >- SheetUtil.canComputeColumnWidht(font) + "/" + computeCellWidthFixed(font, "1") + "/" + computeCellWidthFixed(font, "w") + "/" + >+ SheetUtil.canComputeColumnWidth(font) + "/" + computeCellWidthFixed(font, "1") + "/" + computeCellWidthFixed(font, "w") + "/" + > computeCellWidthFixed(font, "1w") + "/" + computeCellWidthFixed(font, "0000") + "/" + computeCellWidthFixed(font, longValue); > assertTrue("Expected to have cell width > 0 when computing manually, but had " + info, widthManual > 0); > assertTrue("Expected to have cell width > 0 BEFORE auto-size, but had " + info, widthBeforeCell > 0); >Index: src/testcases/org/apache/poi/ss/util/TestSheetUtil.java >=================================================================== >--- src/testcases/org/apache/poi/ss/util/TestSheetUtil.java (revision 1712217) >+++ src/testcases/org/apache/poi/ss/util/TestSheetUtil.java (working copy) >@@ -72,7 +72,7 @@ > Workbook wb = new HSSFWorkbook(); > > // cannot check on result because on some machines we get back false here! >- SheetUtil.canComputeColumnWidht(wb.getFontAt((short)0)); >+ SheetUtil.canComputeColumnWidth(wb.getFontAt((short)0)); > > wb.close(); > } View Attachment As Diff View Attachment As Raw

This is ASF Bugzilla: the Apache Software Foundation bug system. In case of problems with the functioning of ASF Bugzilla, please contact bugzilla-admin@apache.org. Please Note: this e-mail address is only for reporting problems with ASF Bugzilla. Mail about any other subject will be silently ignored.

• • Home
  • | New
  • | Browse
  • | Search
  • |
    [?]
  • | Reports
  • | Help
  • | New Account
  • | Log In
    Remember [x]
  • | Forgot Password
    Login: [x]