Attachment 3329 Details for Bug 13224 – patch to handle "=Name" formula (it works, but Im no expert in excel so please check)

[patch] patch to handle "=Name" formula (it works, but Im no expert in excel so please check)

file1.patch (text/plain), 1.29 KB, created by Mark O'Donohue on 2002-10-03 05:25:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark O'Donohue

Created: 2002-10-03 05:25:33 UTC

Size: 1.29 KB

patch

obsolete

>Index: ./src/java/org/apache/poi/hssf/record/formula/NamePtg.java
>===================================================================
>RCS file: /home/cvspublic/jakarta-poi/src/java/org/apache/poi/hssf/record/formula/NamePtg.java,v
>retrieving revision 1.5
>diff -u -r1.5 NamePtg.java
>--- ./src/java/org/apache/poi/hssf/record/formula/NamePtg.java	5 Sep 2002 00:26:26 -0000	1.5
>+++ ./src/java/org/apache/poi/hssf/record/formula/NamePtg.java	3 Oct 2002 05:08:47 -0000
>@@ -95,9 +95,16 @@
>     public NamePtg(byte [] data, int offset)
>     {
>         offset++;
>-        field_1_ixti        = LittleEndian.getShort(data, offset);
>-        field_2_label_index = LittleEndian.getShort(data, offset + 2);
>-        field_3_zero        = LittleEndian.getShort(data, offset + 4);
>+        if (data.length >= offset + 6) {
>+            field_1_ixti        = LittleEndian.getShort(data, offset);
>+            field_2_label_index = LittleEndian.getShort(data, offset + 2);
>+            field_3_zero        = LittleEndian.getShort(data, offset + 4);
>+        }
>+        else {
>+            field_1_ixti        = 0;
>+            field_2_label_index = LittleEndian.getShort(data, offset );
>+            field_3_zero        = LittleEndian.getShort(data, offset + 2);
>+        }
>     }
> 
>     public void writeBytes(byte [] array, int offset)

Actions: View | Diff

Attachments on bug 13224: 3323 | 3329