[patch] lazily cache the cell cache key hash

patch-57840-cell-eval-cache-lazy-hash.txt (text/plain), 874 bytes, created by Greg Woolsey on 2016-06-11 07:58:56 UTC

(hide)

Description: lazily cache the cell cache key hash

Filename:

MIME Type:

Creator: Greg Woolsey

Created: 2016-06-11 07:58:56 UTC

Size: 874 bytes

patch

obsolete

>Index: src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFEvaluationSheet.java >=================================================================== >--- src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFEvaluationSheet.java (revision 1747850) >+++ src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFEvaluationSheet.java (working copy) >@@ -62,16 +62,16 @@ > private static class CellKey { > private final int _row; > private final int _col; >- private final int _hash; >+ private int _hash = -1; > > protected CellKey(int row, int col) { > _row = row; > _col = col; >- _hash = (17 * 37 + row) * 37 + col; > } > > @Override > public int hashCode() { >+ if( _hash == -1 ) _hash = (17 * 37 + _row) * 37 + _col; > return _hash; > } View Attachment As Diff View Attachment As Raw

This is ASF Bugzilla: the Apache Software Foundation bug system. In case of problems with the functioning of ASF Bugzilla, please contact bugzilla-admin@apache.org. Please Note: this e-mail address is only for reporting problems with ASF Bugzilla. Mail about any other subject will be silently ignored.

• • Home
  • | New
  • | Browse
  • | Search
  • |
    [?]
  • | Reports
  • | Help
  • | New Account
  • | Log In
    Remember [x]
  • | Forgot Password
    Login: [x]