ASF Bugzilla – Attachment 34334 Details for
Bug 60219
[PATCH] FormulaParser can't parse external references when sheet name is quoted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
FormulaParser.java patch content ASCII
patch.txt (text/plain), 1.49 KB, created by
IgnacioHR
on 2016-10-07 17:21:26 UTC
(
hide
)
Description:
FormulaParser.java patch content ASCII
Filename:
MIME Type:
Creator:
IgnacioHR
Created:
2016-10-07 17:21:26 UTC
Size:
1.49 KB
patch
obsolete
>Index: src/java/org/apache/poi/ss/formula/FormulaParser.java >=================================================================== >--- src/java/org/apache/poi/ss/formula/FormulaParser.java (revision 1763803) >+++ src/java/org/apache/poi/ss/formula/FormulaParser.java (working copy) >@@ -1119,6 +1119,17 @@ > return sb.toString(); > } > } >+ >+ private String getBookName() { >+ StringBuilder sb = new StringBuilder(); >+ GetChar(); >+ while (look != ']') { >+ sb.append(look); >+ GetChar(); >+ } >+ GetChar(); >+ return sb.toString(); >+ } > > /** > * Note - caller should reset {@link #_pointer} upon <code>null</code> result >@@ -1127,22 +1138,18 @@ > private SheetIdentifier parseSheetName() { > String bookName; > if (look == '[') { >- StringBuilder sb = new StringBuilder(); >- GetChar(); >- while (look != ']') { >- sb.append(look); >- GetChar(); >- } >- GetChar(); >- bookName = sb.toString(); >+ bookName = getBookName(); > } else { > bookName = null; > } > > if (look == '\'') { >+ Match('\''); >+ >+ if (look == '[') >+ bookName = getBookName(); >+ > StringBuffer sb = new StringBuffer(); >- >- Match('\''); > boolean done = look == '\''; > while(!done) { > sb.append(look);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 60219
:
34334
|
34342
|
34354
|
34357