[patch] Add Iterable interface to URLCollection to get even nearer to PR #221

0007-Add-Iterable-interface-to-URLCollection.patch (text/plain), 2.67 KB, created by Felix Schumacher on 2016-11-27 11:50:03 UTC

(hide)

Description: Add Iterable interface to URLCollection to get even nearer to PR #221

Filename:

MIME Type:

Creator: Felix Schumacher

Created: 2016-11-27 11:50:03 UTC

Size: 2.67 KB

patch

obsolete

>From 8fcf11f450d4080c6126fdb7d9a65187996868ac Mon Sep 17 00:00:00 2001 >From: Felix Schumacher <felix.schumacher@internetallee.de> >Date: Sun, 27 Nov 2016 12:48:27 +0100 >Subject: [PATCH 7/7] Add Iterable interface to URLCollection > >--- > .../http/org/apache/jmeter/protocol/http/parser/CssParser.java | 9 ++------- > .../org/apache/jmeter/protocol/http/parser/URLCollection.java | 3 ++- > 2 files changed, 4 insertions(+), 8 deletions(-) > >diff --git a/src/protocol/http/org/apache/jmeter/protocol/http/parser/CssParser.java b/src/protocol/http/org/apache/jmeter/protocol/http/parser/CssParser.java >index 19cc630..ceaeb28 100644 >--- a/src/protocol/http/org/apache/jmeter/protocol/http/parser/CssParser.java >+++ b/src/protocol/http/org/apache/jmeter/protocol/http/parser/CssParser.java >@@ -23,6 +23,7 @@ import java.nio.charset.Charset; > import java.util.Collections; > import java.util.Iterator; > >+import org.apache.commons.lang3.StringUtils; > import org.apache.commons.lang3.Validate; > import org.apache.commons.lang3.tuple.ImmutableTriple; > import org.apache.commons.lang3.tuple.Triple; >@@ -70,13 +71,7 @@ public class CssParser implements LinkExtractorParser { > final URLCollection urlCollection = orDefault(CSS_URL_CACHE.get(triple), EMPTY_URL_COLLECTION); > > if (LOG.isDebugEnabled()) { >- StringBuilder builder = new StringBuilder(); >- for (Iterator<URL> iterator = urlCollection.iterator(); iterator >- .hasNext();) { >- URL urlString = iterator.next(); >- builder.append(urlString).append(','); >- } >- LOG.debug("Parsed:" + baseUrl + ", got:" + builder.toString()); >+ LOG.debug("Parsed:" + baseUrl + ", got:" + StringUtils.join(urlCollection, ",")); > } > > return urlCollection.iterator(); >diff --git a/src/protocol/http/org/apache/jmeter/protocol/http/parser/URLCollection.java b/src/protocol/http/org/apache/jmeter/protocol/http/parser/URLCollection.java >index fb913c8..21ca5aa 100644 >--- a/src/protocol/http/org/apache/jmeter/protocol/http/parser/URLCollection.java >+++ b/src/protocol/http/org/apache/jmeter/protocol/http/parser/URLCollection.java >@@ -39,7 +39,7 @@ import org.apache.log.Logger; > * does not support remove() > * > */ >-public class URLCollection { >+public class URLCollection implements Iterable<URL> { > private static final Logger log = LoggingManager.getLoggerForClass(); > private final Collection<URLString> coll; > >@@ -99,6 +99,7 @@ public class URLCollection { > return b; > } > >+ @Override > public Iterator<URL> iterator() { > return new UrlIterator(coll.iterator()); > } >-- >2.7.4 > View Attachment As Diff View Attachment As Raw

This is ASF Bugzilla: the Apache Software Foundation bug system. In case of problems with the functioning of ASF Bugzilla, please contact bugzilla-admin@apache.org. Please Note: this e-mail address is only for reporting problems with ASF Bugzilla. Mail about any other subject will be silently ignored.

• • Home
  • | New
  • | Browse
  • | Search
  • |
    [?]
  • | Reports
  • | Help
  • | New Account
  • | Log In
    Remember [x]
  • | Forgot Password
    Login: [x]