ASF Bugzilla – Attachment 35026 Details for
Bug 61145
Missing @Documented annotation in some javax.annotation classes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch validated against tomcat tests and the corresponding specification
added-documented-annotation.diff (text/plain), 6.91 KB, created by
Katya Todorova
on 2017-06-02 07:46:23 UTC
(
hide
)
Description:
Patch validated against tomcat tests and the corresponding specification
Filename:
MIME Type:
Creator:
Katya Todorova
Created:
2017-06-02 07:46:23 UTC
Size:
6.91 KB
patch
obsolete
>From 5cf7f15da47eeebdf5f7843af613b4b48bb3a949 Mon Sep 17 00:00:00 2001 >From: Katya Todorova <katya.k.todorova@gmail.com> >Date: Fri, 2 Jun 2017 10:28:51 +0300 >Subject: [PATCH] Fix missing @Documented in some javax.annotation classes > >--- > java/javax/annotation/Generated.java | 2 ++ > java/javax/annotation/PostConstruct.java | 2 ++ > java/javax/annotation/PreDestroy.java | 2 ++ > java/javax/annotation/Priority.java | 2 ++ > java/javax/annotation/Resources.java | 2 ++ > java/javax/annotation/security/DeclareRoles.java | 2 ++ > java/javax/annotation/security/DenyAll.java | 2 ++ > java/javax/annotation/security/PermitAll.java | 2 ++ > java/javax/annotation/security/RolesAllowed.java | 2 ++ > java/javax/annotation/security/RunAs.java | 2 ++ > 10 files changed, 20 insertions(+) > >diff --git a/java/javax/annotation/Generated.java b/java/javax/annotation/Generated.java >index f441714..ed82843 100644 >--- a/java/javax/annotation/Generated.java >+++ b/java/javax/annotation/Generated.java >@@ -20,10 +20,12 @@ import java.lang.annotation.ElementType; > import java.lang.annotation.Retention; > import java.lang.annotation.RetentionPolicy; > import java.lang.annotation.Target; >+import java.lang.annotation.Documented; > > /** > * @since Common Annotations 1.0 > */ >+@Documented > @Target({ElementType.ANNOTATION_TYPE, ElementType.CONSTRUCTOR, > ElementType.FIELD, ElementType.LOCAL_VARIABLE, ElementType.METHOD, > ElementType.PACKAGE, ElementType.PARAMETER, ElementType.TYPE}) >diff --git a/java/javax/annotation/PostConstruct.java b/java/javax/annotation/PostConstruct.java >index 4382b25..d72cff1 100644 >--- a/java/javax/annotation/PostConstruct.java >+++ b/java/javax/annotation/PostConstruct.java >@@ -20,10 +20,12 @@ import java.lang.annotation.ElementType; > import java.lang.annotation.Retention; > import java.lang.annotation.RetentionPolicy; > import java.lang.annotation.Target; >+import java.lang.annotation.Documented; > > /** > * @since Common Annotations 1.0 > */ >+@Documented > @Target(ElementType.METHOD) > @Retention(RetentionPolicy.RUNTIME) > public @interface PostConstruct { >diff --git a/java/javax/annotation/PreDestroy.java b/java/javax/annotation/PreDestroy.java >index a774b7b..0423b67 100644 >--- a/java/javax/annotation/PreDestroy.java >+++ b/java/javax/annotation/PreDestroy.java >@@ -20,10 +20,12 @@ import java.lang.annotation.ElementType; > import java.lang.annotation.Retention; > import java.lang.annotation.RetentionPolicy; > import java.lang.annotation.Target; >+import java.lang.annotation.Documented; > > /** > * @since Common Annotations 1.0 > */ >+@Documented > @Target(ElementType.METHOD) > @Retention(RetentionPolicy.RUNTIME) > public @interface PreDestroy { >diff --git a/java/javax/annotation/Priority.java b/java/javax/annotation/Priority.java >index fe9d3f0..f129815 100644 >--- a/java/javax/annotation/Priority.java >+++ b/java/javax/annotation/Priority.java >@@ -20,10 +20,12 @@ import java.lang.annotation.ElementType; > import java.lang.annotation.Retention; > import java.lang.annotation.RetentionPolicy; > import java.lang.annotation.Target; >+import java.lang.annotation.Documented; > > /** > * @since Common Annotations 1.2 > */ >+@Documented > @Target(ElementType.TYPE) > @Retention(RetentionPolicy.RUNTIME) > public @interface Priority { >diff --git a/java/javax/annotation/Resources.java b/java/javax/annotation/Resources.java >index 91bbb59..d50cb8f 100644 >--- a/java/javax/annotation/Resources.java >+++ b/java/javax/annotation/Resources.java >@@ -20,10 +20,12 @@ import java.lang.annotation.ElementType; > import java.lang.annotation.Retention; > import java.lang.annotation.RetentionPolicy; > import java.lang.annotation.Target; >+import java.lang.annotation.Documented; > > /** > * @since Common Annotations 1.0 > */ >+@Documented > @Target(ElementType.TYPE) > @Retention(RetentionPolicy.RUNTIME) > public @interface Resources { >diff --git a/java/javax/annotation/security/DeclareRoles.java b/java/javax/annotation/security/DeclareRoles.java >index fb21081..3d54604 100644 >--- a/java/javax/annotation/security/DeclareRoles.java >+++ b/java/javax/annotation/security/DeclareRoles.java >@@ -20,10 +20,12 @@ import java.lang.annotation.ElementType; > import java.lang.annotation.Retention; > import java.lang.annotation.RetentionPolicy; > import java.lang.annotation.Target; >+import java.lang.annotation.Documented; > > /** > * @since Common Annotations 1.0 > */ >+@Documented > @Target(ElementType.TYPE) > @Retention(RetentionPolicy.RUNTIME) > public @interface DeclareRoles { >diff --git a/java/javax/annotation/security/DenyAll.java b/java/javax/annotation/security/DenyAll.java >index 7757236..4562ff8 100644 >--- a/java/javax/annotation/security/DenyAll.java >+++ b/java/javax/annotation/security/DenyAll.java >@@ -20,10 +20,12 @@ import java.lang.annotation.ElementType; > import java.lang.annotation.Retention; > import java.lang.annotation.RetentionPolicy; > import java.lang.annotation.Target; >+import java.lang.annotation.Documented; > > /** > * @since Common Annotations 1.0 > */ >+@Documented > @Target({ElementType.METHOD, ElementType.TYPE}) > @Retention(RetentionPolicy.RUNTIME) > public @interface DenyAll { >diff --git a/java/javax/annotation/security/PermitAll.java b/java/javax/annotation/security/PermitAll.java >index 54335f3..92629b1 100644 >--- a/java/javax/annotation/security/PermitAll.java >+++ b/java/javax/annotation/security/PermitAll.java >@@ -20,10 +20,12 @@ import java.lang.annotation.ElementType; > import java.lang.annotation.Retention; > import java.lang.annotation.RetentionPolicy; > import java.lang.annotation.Target; >+import java.lang.annotation.Documented; > > /** > * @since Common Annotations 1.0 > */ >+@Documented > @Target({ElementType.TYPE, ElementType.METHOD}) > @Retention(RetentionPolicy.RUNTIME) > public @interface PermitAll { >diff --git a/java/javax/annotation/security/RolesAllowed.java b/java/javax/annotation/security/RolesAllowed.java >index 8739dfe..4af0d27 100644 >--- a/java/javax/annotation/security/RolesAllowed.java >+++ b/java/javax/annotation/security/RolesAllowed.java >@@ -20,10 +20,12 @@ import java.lang.annotation.ElementType; > import java.lang.annotation.Retention; > import java.lang.annotation.RetentionPolicy; > import java.lang.annotation.Target; >+import java.lang.annotation.Documented; > > /** > * @since Common Annotations 1.0 > */ >+@Documented > @Target({ElementType.TYPE, ElementType.METHOD}) > @Retention(RetentionPolicy.RUNTIME) > public @interface RolesAllowed { >diff --git a/java/javax/annotation/security/RunAs.java b/java/javax/annotation/security/RunAs.java >index 5479ba1..fa1e14e 100644 >--- a/java/javax/annotation/security/RunAs.java >+++ b/java/javax/annotation/security/RunAs.java >@@ -20,10 +20,12 @@ import java.lang.annotation.ElementType; > import java.lang.annotation.Retention; > import java.lang.annotation.RetentionPolicy; > import java.lang.annotation.Target; >+import java.lang.annotation.Documented; > > /** > * @since Common Annotations 1.0 > */ >+@Documented > @Target(ElementType.TYPE) > @Retention(RetentionPolicy.RUNTIME) > public @interface RunAs { >-- >2.8.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 61145
: 35026