Attachment 35290 Details for Bug 61489 – Make creation of command line parameters from GET parameters optional

[patch] Make creation of command line parameters from GET parameters optional

CGIServlet.java.CmdLineArguments.patch (text/plain), 1.49 KB, created by jm009 on 2017-09-05 07:10:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: jm009

Created: 2017-09-05 07:10:35 UTC

Size: 1.49 KB

patch

obsolete

>Index: java/org/apache/catalina/servlets/CGIServlet.java
>===================================================================
>--- java/org/apache/catalina/servlets/CGIServlet.java	(revision 1807314)
>+++ java/org/apache/catalina/servlets/CGIServlet.java	(working copy)
>@@ -282,6 +282,12 @@
>     /** the shell environment variables to be passed to the CGI script */
>     private final Hashtable<String,String> shellEnv = new Hashtable<>();
> 
>+    /** enable creation of script command line arguments from query-string. 
>+     * See https://tools.ietf.org/html/rfc3875#section-4.4
>+     * 4.4.  The Script Command Line
>+     */
>+    private boolean enableCmdLineArguments = false;
>+    
>     /**
>      * Sets instance variables.
>      * <P>
>@@ -341,6 +347,9 @@
>             envHttpHeadersPattern =
>                     Pattern.compile(getServletConfig().getInitParameter("envHttpHeaders"));
>         }
>+        
>+        enableCmdLineArguments =
>+        		    Boolean.parseBoolean(config.getInitParameter("enableCmdLineArguments"));
>     }
> 
> 
>@@ -680,7 +689,7 @@
>                 } else {
>                     qs = req.getQueryString();
>                 }
>-                if (qs != null && qs.indexOf('=') == -1) {
>+                if (enableCmdLineArguments && qs != null && qs.indexOf('=') == -1) {
>                     StringTokenizer qsTokens = new StringTokenizer(qs, "+");
>                     while ( qsTokens.hasMoreTokens() ) {
>                         cmdLineParameters.add(URLDecoder.decode(qsTokens.nextToken(),

Actions: View | Diff

Attachments on bug 61489: 35290 | 35293