ASF Bugzilla – Attachment 35756 Details for
Bug 62165
OldExcelExtractor closed NPOIFSFileSystem too early
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
OldExcelExtractor patch file to fix the open stream bug
OldExcelExtractor.patch (text/plain), 806 bytes, created by
Billow
on 2018-03-08 17:27:25 UTC
(
hide
)
Description:
OldExcelExtractor patch file to fix the open stream bug
Filename:
MIME Type:
Creator:
Billow
Created:
2018-03-08 17:27:25 UTC
Size:
806 bytes
patch
obsolete
>diff --git a/src/java/org/apache/poi/hssf/extractor/OldExcelExtractor.java b/src/java/org/apache/poi/hssf/extractor/OldExcelExtractor.java >index 922db321..e408eb39 100644 >--- a/src/java/org/apache/poi/hssf/extractor/OldExcelExtractor.java >+++ b/src/java/org/apache/poi/hssf/extractor/OldExcelExtractor.java >@@ -130,8 +130,11 @@ public class OldExcelExtractor implements Closeable { > NPOIFSFileSystem poifs = new NPOIFSFileSystem(bis); > try { > open(poifs); >+ toClose = poifs; // Fixed by GR, we should not close it here > } finally { >- poifs.close(); >+ if (toClose == null) { >+ poifs.close(); >+ } > } > } else { > ris = new RecordInputStream(bis);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 62165
: 35756