[patch] Fix crash when shm_cleanup() called twice with same handles

shm.patch (text/plain), 686 bytes, created by Chuck Hunley on 2018-07-10 19:28:40 UTC

(hide)

Description: Fix crash when shm_cleanup() called twice with same handles

Filename:

MIME Type:

Creator: Chuck Hunley

Created: 2018-07-10 19:28:40 UTC

Size: 686 bytes

patch

obsolete

>--- shm-old.c 2018-07-10 14:58:01.671807000 -0400 >+++ shm.c 2018-07-10 15:02:07.405678000 -0400 >@@ -41,12 +41,19 @@ > { > apr_status_t rv = APR_SUCCESS; > apr_shm_t *m = shm; >- >- if (!UnmapViewOfFile(m->memblk)) { >+ >+ if (m->memblk) { >+ if (!UnmapViewOfFile(m->memblk)) { > rv = apr_get_os_error(); >+ } >+ m->memblk = NULL; > } >- if (!CloseHandle(m->hMap)) { >- rv = rv != APR_SUCCESS ? rv : apr_get_os_error(); >+ >+ if (m->hMap) { >+ if (!CloseHandle(m->hMap)) { >+ rv = rv != APR_SUCCESS ? rv : apr_get_os_error(); >+ } >+ m->hMap = NULL; > } > if (m->filename) { > /* Remove file if file backed */ View Attachment As Diff View Attachment As Raw

This is ASF Bugzilla: the Apache Software Foundation bug system. In case of problems with the functioning of ASF Bugzilla, please contact bugzilla-admin@apache.org. Please Note: this e-mail address is only for reporting problems with ASF Bugzilla. Mail about any other subject will be silently ignored.

• • Home
  • | New
  • | Browse
  • | Search
  • |
    [?]
  • | Reports
  • | Help
  • | New Account
  • | Log In
    Remember [x]
  • | Forgot Password
    Login: [x]