ASF Bugzilla – Attachment 36529 Details for
Bug 62040
Quotient.evaluate function does not accept cell refences
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Modifications to Quotient.java and QuotientFunctionTestCaseData.xls
Quotient.patch (text/plain), 4.91 KB, created by
Ian Giguère
on 2019-04-16 18:02:11 UTC
(
hide
)
Description:
Modifications to Quotient.java and QuotientFunctionTestCaseData.xls
Filename:
MIME Type:
Creator:
Ian Giguère
Created:
2019-04-16 18:02:11 UTC
Size:
4.91 KB
patch
obsolete
>Index: src/java/org/apache/poi/ss/formula/functions/Quotient.java >IDEA additional info: >Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP ><+>UTF-8 >=================================================================== >--- src/java/org/apache/poi/ss/formula/functions/Quotient.java (revision 2b3cad47b42b49cb82922a611f326d2d6d72519c) >+++ src/java/org/apache/poi/ss/formula/functions/Quotient.java (date 1555437518000) >@@ -45,14 +45,16 @@ > > double enumerator = 0; > try { >- enumerator = OperandResolver.coerceValueToDouble(venumerator); >+ ValueEval ve = OperandResolver.getSingleValue(venumerator, srcRowIndex, srcColumnIndex); >+ enumerator = OperandResolver.coerceValueToDouble(ve); > } catch (EvaluationException e) { > return ErrorEval.VALUE_INVALID; > } > > double denominator = 0; > try { >- denominator = OperandResolver.coerceValueToDouble(vedenominator); >+ ValueEval ve = OperandResolver.getSingleValue(vedenominator, srcRowIndex, srcColumnIndex); >+ denominator = OperandResolver.coerceValueToDouble(ve); > } catch (EvaluationException e) { > return ErrorEval.VALUE_INVALID; > } >diff --git test-data/spreadsheet/QuotientFunctionTestCaseData.xls test-data/spreadsheet/QuotientFunctionTestCaseData.xls >index 729e77485071fc9460913a7bcc91f565e4ac4aeb..7890e1605999cccb18ef82224f7c4f6ac9c9ceeb >GIT binary patch >literal 9728 >zc%1E7U2Ggz6+ScjH|wAHr%l{n_tyQfle$aO6wxMW<Jd`P9$J^w6$n+(@$RfW&Fsu} >zX4Z~DfD0{8RBF`+UMiuY^Z_AS5Ndg#63zosA6kKcK7f!&c|ag|a8aQuYO;Li%*^h1 >zvkp#*5K(h?@7#ONJ@=e*&pG#R=9j-1I{o60u6c(#(mu-2*=CXQDV&Bpm;k73i*aY0 >z&1QmbUQU-(Iun-}_%4f_LuQ{BkPYM_au0GZavySk?C&HG#qi~HX{KZ3;TMvk!{nm$ >zX{B>1IB(j4h)MI?N}sb^q}yt`EdS!=7Y!`r`5gVU|4p9qGWXvhoqm`-g(uM;ksqZx >zuMIP%Q&#`0G%Y%q8tbrzP3B%Li@ipt7m&BnD}sMrp7+vlG?Xb)cgudH(R<pIX#b2n >z$K<&UPmO*eeSRmH-84$SCtl~C<!(R~v>7tVA)Dqg6KqgiLvOH!za|t&IqjgdFx5wE >zO=Q2Wcb7ey?W2>t4u9HmE#GuTvw3=n$2WDFu0)rU^pB=Wd38-Oo<#}%y{+N(3&hjM >z4u2B1Q`An0J#UNX*E{h$H^EPCg5R|XzStEX=`%re)h77sHsW)M{zfPLOA$W1$#^%z >zr}#XtgJ_kSTn?^gq#Rn!OF6unmGX+!f|OUT=9-Vm+<Te^=oLOnAhwTLW<@<<J&n`k >zO9PBD=rav3v@JLM7BtZDds*XB%f2iNfVTIh*jYmR$n4zF!w=5sblu2^OmLq3{5y-o >z$yIbSllAnredji6^Ok?mx6FM+U#73X$bGQnsIV)v={(n(UYT{Ry}Tgyg5p-j_N6!l >zw!7e1GoI6^x%=2!298NRpuCA&i|0@t^OpDV=_&`2{oNRbi@pV+b6f~z0qpwdlx83k >z%{`;hU$HX4O6#AO4*7KzS%LWM7B3?4`q!@Sq26^~AAbfygPzoIo-@|4I+8I(qwn%* >z9w#~j?l4A>-^aQBLvr(|6X*LOc+n12P>0DX!J=h_s_eO;X}f`1GJV@?1S+%wV9me^ >zRMqoUxM-<r!!3ul=LUOK;?Mht9yDu~@~T2n0}J(d!?nY>zhef0T3)ovi>kq_!VbB6 >zp^N7)l+3zWUbISe&n^W)2?A>k$1Jr3mgc}Mk$EJ+9`U`}!);!$@5CIG;Guwwbt+qq >zqsHTS9KZ449tH7euiAdis;K!D(VA7=StdHXWce#9vd6p?*p)<KkYg|ipSGD|6_vGQ >zIt`Q6Nm~q7FjWwmZpHK~b^uXKZ-%8Oh-O{od&}xB*3ZJIBY~6Lr!0XNsOia>$wRD~ >zZz&Twlu>b;TEtiodVv}{5@|3tsm2bUs9WU_QjS?c!wJU}1go(buU3N{#y(_sN264B >zh)oAIRq>WxRfPdXnNMPH%TQIRh8x-rl#lFkB2;7hEw^&t7#ptYHNdx}r#e`|mX0X^ >z58L4)D1+m6ok`miqQ1T0dOoz9KnPSDj>J>B;rmd|S%Ji$QLlSG>pyQTno9^je<xVa >zvH_N1y*9V9>4JtssS<ICh6sa*!VA9FsIy&tR%+gIyycQQMRYWZ&e&Jz>x-QvLL%1F >zFbJ&TdLd#sgj0k*F>6fT9@osI5Tqh~*+!)K7LNngtD3gc@GT6212+K!wSdSnT}Tlv >z#A?hZuq2?xZS0PCSOJ2f3gk-ZyF}BifVARxyeo;9$qhaX&e5$kGz2b>h*>I+tt%5m >z!d2AZKxCa!Pd9I{Iu<fGE%cyts9^0#f*G16O~YZ*XEt8LVPC4yJZ`y6%fdYu{c6C7 >zEOtdSQ4*834DZ3?ZT$44nr}d5C-9h)FbH7GcE8q~6bXS{t2>r*B+{K&jtt6fjRdpK >zww5p&%M5Jv!8$NrHv@?ywvcT)<I&`3g$G2#>4D|2tKx7QH-nh}xbo`k!O}LOhh_bU >zC*R&ZKtvj`p#l!MLst3D`>hkOCo`Id3S~@_g$C2d{IF@o(;GWO$LvO1GP4ocSn3ww >zD2_XhAh3VP{=~s0Z^5kio|?F0=ZNf&JnJ!EY>oq0V7q)ZQN?n-n(dz3hApIGFWD8* >za7BH|@;zuWV@Z%#u`an~E5If-TL)*ivb$ZqGe;y#MiV>T2#w~WHw<NCJ92wt+#Z)Y >zzlMmeD}x)ZD}C7PD%cqLct0c?-ypWS55M>BuO66x=)e~RzuG>x&@Fsyp-JsYw4BQB >zk{-9o^Xo!;Wi0d?f_qAyx1xVl(w`2Dr|J_ezJETjGgW^PmkteDMduM6(k8Xu*B-<F >z^ns+*=n=FOa0-#r5IyG%h%AP&b!+b%5ls3vX^##Iyr~=dU|gS!t`^#W;Iu9{y$deW >z1()lB%Xh&Q1ou=XjWY!IIX#UlcER;@^gSaOB02gAqzR<OkS>rOLm7cGF_aT18$)@4 >zaxqj859VWtwc8;$hKkZ=#88hwjQbls#In}!kK$+Dh;7XxAa(tYNZ$H{;EU_67on-7 >zQ;+oHKCH`q`Y^pFEmJ9~>zQ9{0}O|23pjl(7->dYa+$x>qP}>6QSao_QLj;Rpbhi+ >z|GC|5n2psOYr|RmUL9=1e7t_OzYXW{OSc#BOJ)_rd?da}Z^L{WXlB}QKYr=<ZCz$% >z^kf@EvyxrfIRiE5**OEV&~+m&+of-=3ohRUSLlK>y2vd8m+!#!biws@>C65xX#WOW >zKW$tg&ct(kM9K)#5v9G9%xG@wYe71o{uY#>k?5m>o)-&U1--__E(1vzPesKL-J{9$ >z9L>?FPScqteH9x7Ulp$wp?TbVa;c8%2cq)&q~i?{JUn&7TW@kQrV=JOVUianw~MtC >zCdOJ+j&v}&d2KY)(jhP1|B30#-3w{uH|f4(Ej5IKbpMxh-y=S3b*IiDxZk{X{ev5e >zQ#b6I{`D>2eCH2`5+;T)Nfu56#vBkfc})4Du+#-k-UDt=SdL`r;PlL)Sf4yRP!v*~ >zcBRO1-`*9irObFR_E-^?yGBIxoKFNi7E4J)^qfaTkBAtGMfAiXZkGV<6fts+VQ{fe >zg!G<ANUsPPjt$h;CEi-v-;7me4UfWFV(UI(oP>Lyu)3lJWdZTh8d2tAF;QC{(Dqha >zA;pEK!~iy}joXq+Z%f8SY)eLJTgs<K7l#%24aMh$A>LE;|FA7xPM3a4zTa|AzW;H( >zK$pMkeH;?MD$Vpn-;f54=(N5Tg~pL<@p!;4`(EHxLv{EB?)d7SPu)Ie&f|7x$qqSf >zSF3k_#Q4)cO8>J>lA~r9zI6KO@BICP*~P){KWETw<3Ii_ua(ad#aEbU_2Zc5wUw^` >za}=#>k5P2lawxiyo}lQv_fr%p`<F8$uZ+2_s9oP3^ITo|`4@;buC7wwzi;*A6L0X_ >zR~oi|u(<TzZ?w(ym-o4EzxDPDrE3SD|2FiW{NUw7z~wq{k5cq0AbIaQn9^}Gd^-I% >zzyFGyju`6JXCN6M(q|#vr{gp)dK|wX*_?*u5E=QAb=XQDrr*CKs%ta@xizZOEOdDM >zqU2|&{S9`j{f<&1e-?3OU9j9F@!2UopSRM7$De#e$<f2q!1!xqitmpi3aa80#)M>} >y?w*I&L@b~8jjhUOd#$zPAA*Fk=wL|%UYI_2U&Q!%;R?4xxW#m#^8cT{|Nk2nTYTLB >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 62040
: 36529 |
36530
|
36531