ASF Bugzilla – Attachment 36737 Details for
Bug 63700
[PATCH] Make D* functions work with numeric result column
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
dget_num_col.patch
dget_num_col.patch (text/plain), 1.07 KB, created by
Patrick Böker
on 2019-08-27 07:48:17 UTC
(
hide
)
Description:
dget_num_col.patch
Filename:
MIME Type:
Creator:
Patrick Böker
Created:
2019-08-27 07:48:17 UTC
Size:
1.07 KB
patch
obsolete
>diff --git a/src/java/org/apache/poi/ss/formula/functions/DStarRunner.java b/src/java/org/apache/poi/ss/formula/functions/DStarRunner.java >index b55ba808b..14d3920ee 100644 >--- a/src/java/org/apache/poi/ss/formula/functions/DStarRunner.java >+++ b/src/java/org/apache/poi/ss/formula/functions/DStarRunner.java >@@ -158,8 +158,17 @@ public final class DStarRunner implements Function3Arg { > */ > private static int getColumnForName(ValueEval nameValueEval, AreaEval db) > throws EvaluationException { >- String name = OperandResolver.coerceValueToString(nameValueEval); >- return getColumnForString(db, name); >+ if (nameValueEval instanceof NumericValueEval) { >+ int columnNo = OperandResolver.coerceValueToInt(nameValueEval) - 1; >+ if (columnNo < 0 || columnNo >= db.getWidth()) { >+ return -1; >+ } >+ return columnNo; >+ } >+ else { >+ String name = OperandResolver.coerceValueToString(nameValueEval); >+ return getColumnForString(db, name); >+ } > } > > /**
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 63700
: 36737 |
36738