Attachment 36848 Details for Bug 63855 – Send 100-continue (if needed) when spooling the request body (v2)

[patch] Send 100-continue (if needed) when spooling the request body (v2)

proxy_spool_100_continue-v2.diff (text/plain), 1.01 KB, created by Yann Ylavic on 2019-10-19 14:21:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Yann Ylavic

Created: 2019-10-19 14:21:39 UTC

Size: 1.01 KB

patch

obsolete

>Index: modules/proxy/mod_proxy_http.c
>===================================================================
>--- modules/proxy/mod_proxy_http.c	(revision 1868625)
>+++ modules/proxy/mod_proxy_http.c	(working copy)
>@@ -438,6 +438,21 @@ static int spool_reqbody_cl(proxy_http_req_t *req,
>     apr_file_t *tmpfile = NULL;
>     apr_off_t limit;
> 
>+    /*
>+     * Tell the HTTP_IN filter that it should send a "100 continue" if the
>+     * client expects one, before blocking on the body, otherwise we'd wait
>+     * for each other.
>+     */
>+    if (req->expecting_100) {
>+        /* From https://tools.ietf.org/html/rfc7231#section-5.1.1
>+         *   A server MAY omit sending a 100 (Continue) response if it has
>+         *   already received some or all of the message body for the
>+         *   corresponding request, or if [snip].
>+         */
>+        r->expecting_100 = APR_BRIGADE_EMPTY(input_brigade);
>+        req->expecting_100 = 0;
>+    }
>+
>     body_brigade = apr_brigade_create(p, bucket_alloc);
>     *bytes_spooled = 0;
>

Actions: View | Diff

Attachments on bug 63855: 36834 | 36835 | 36836 | 36837 | 36838 | 36848 | 36849