Attachment 37219 Details for Bug 64413 – A patch to improve the error message for dav_fs_open_stream

[patch] A patch to improve the error message for dav_fs_open_stream

dav_fs_open_stream.patch (text/plain), 1.39 KB, created by Bingyu Shen on 2020-05-07 01:43:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bingyu Shen

Created: 2020-05-07 01:43:08 UTC

Size: 1.39 KB

patch

obsolete

>Index: modules/dav/fs/repos.c
>===================================================================
>--- modules/dav/fs/repos.c	(revision 1877459)
>+++ modules/dav/fs/repos.c	(working copy)
>@@ -948,15 +948,26 @@
>         else if (APR_STATUS_IS_EEXIST(rv)) {
>             rv = apr_file_open(&ds->f, ds->pathname, flags, APR_OS_DEFAULT,
>                                ds->p);
>+            if (rv != APR_SUCCESS) {
>+                return dav_new_error(p, MAP_IO2HTTP(rv), 0, rv,
>+                                    apr_psprintf(p, "Could not open an existing resource for writing: %s.",
>+                                    ds->pathname) );
>+            }
>         }
>     }
>     else {
>         rv = apr_file_open(&ds->f, ds->pathname, flags, APR_OS_DEFAULT, ds->p);
>+        if (rv != APR_SUCCESS) {
>+            return dav_new_error(p, MAP_IO2HTTP(rv), 0, rv,
>+                                apr_psprintf(p, "Could not open an existing resource for reading: %s.",
>+                                ds->pathname) );
>+        }
>     }
> 
>     if (rv != APR_SUCCESS) {
>         return dav_new_error(p, MAP_IO2HTTP(rv), 0, rv,
>-                             "An error occurred while opening a resource.");
>+                            apr_psprintf(p, "An error occurred while opening a resource for writing: %s.",
>+                            ds->pathname) );
>     }
> 
>     /* (APR registers cleanups for the fd with the pool) */

Actions: View | Diff

Attachments on bug 64413: 37219