Attachment 37846 Details for Bug 65283 – Patch

[patch] Patch

file_65283.txt (text/plain), 1.08 KB, created by Bingyu Shen on 2021-05-01 08:11:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bingyu Shen

Created: 2021-05-01 08:11:35 UTC

Size: 1.08 KB

patch

obsolete

>commit 1665a30e9d216dab57e2db930b51cf2cf5debd4b
>Author: Bingyu Shen <ahshenbingyu@gmail.com>
>Date:   Sat May 1 00:13:19 2021 -0700
>
>    handle error return of store array
>
>diff --git a/modules/cache/mod_cache_disk.c b/modules/cache/mod_cache_disk.c
>index 8d17a19..bdc2ece 100644
>--- a/modules/cache/mod_cache_disk.c
>+++ b/modules/cache/mod_cache_disk.c
>@@ -1033,7 +1033,14 @@ static apr_status_t write_headers(cache_handle_t *h, request_rec *r)
>             varray = apr_array_make(r->pool, 6, sizeof(char*));
>             tokens_to_array(r->pool, tmp, varray);
>
>-            store_array(dobj->vary.tempfd, varray);
>+            rv = store_array(dobj->vary.tempfd, varray);
>+            if (rv != APR_SUCCESS) {
>+                ap_log_rerror(APLOG_MARK, APLOG_WARNING, rv, r, APLOGNO()
>+                        "could not write to vary file %s",
>+                        dobj->vary.tempfile);
>+                apr_pool_destroy(dobj->vary.pool);
>+                return rv;
>+            }
>
>             rv = apr_file_close(dobj->vary.tempfd);
>             if (rv != APR_SUCCESS) {

Actions: View | Diff

Attachments on bug 65283: 37846