[patch] Free sctx and sk

ssl_engine_sctx-free.diff (text/plain), 936 bytes, created by Giovanni Bechis on 2022-02-24 12:00:39 UTC

(hide)

Description: Free sctx and sk

Filename:

MIME Type:

Creator: Giovanni Bechis

Created: 2022-02-24 12:00:39 UTC

Size: 936 bytes

patch

obsolete

>Index: modules/ssl/ssl_engine_init.c >=================================================================== >--- modules/ssl/ssl_engine_init.c (revision 1898364) >+++ modules/ssl/ssl_engine_init.c (working copy) >@@ -1846,6 +1846,7 @@ > ap_log_error(APLOG_MARK, APLOG_EMERG, 0, s, APLOGNO(02208) > "SSL proxy client cert initialization failed"); > ssl_log_ssl_error(SSLLOG_MARK, APLOG_EMERG, s); >+ sk_X509_INFO_free(sk); > return ssl_die(s); > } > >@@ -1855,7 +1856,11 @@ > int i; > > X509_INFO *inf = sk_X509_INFO_value(pkp->certs, n); >- X509_STORE_CTX_init(sctx, store, inf->x509, NULL); >+ if (!X509_STORE_CTX_init(sctx, store, inf->x509, NULL)) { >+ sk_X509_INFO_free(sk); >+ X509_STORE_CTX_free(sctx); >+ return ssl_die(s); >+ } > > /* Attempt to verify the client cert */ > if (X509_verify_cert(sctx) != 1) { View Attachment As Diff View Attachment As Raw

This is ASF Bugzilla: the Apache Software Foundation bug system. In case of problems with the functioning of ASF Bugzilla, please contact bugzilla-admin@apache.org. Please Note: this e-mail address is only for reporting problems with ASF Bugzilla. Mail about any other subject will be silently ignored.

• • Home
  • | New
  • | Browse
  • | Search
  • |
    [?]
  • | Reports
  • | Help
  • | New Account
  • | Log In
    Remember [x]
  • | Forgot Password
    Login: [x]