ASF Bugzilla – Attachment 6742 Details for
Bug 20656
GetServerVariable returns improperly terminated header fields given "ALL_HTTP" or "ALL_RAW"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Trivial patch
20656 (text/plain), 1.95 KB, created by
Jesse Pelton
on 2003-06-10 19:29:17 UTC
(
hide
)
Description:
Trivial patch
Filename:
MIME Type:
Creator:
Jesse Pelton
Created:
2003-06-10 19:29:17 UTC
Size:
1.95 KB
patch
obsolete
>--- mod_isapi-old.c Wed Feb 26 09:42:30 2003 >+++ mod_isapi.c Tue Jun 10 15:11:06 2003 >@@ -538,7 +538,7 @@ > > if (!strcmp(variable_name, "ALL_HTTP")) > { >- /* lf delimited, colon split, comma seperated and >+ /* crlf delimited, colon split, comma separated and > * null terminated list of HTTP_ vars > */ > const apr_array_header_t *arr = apr_table_elts(r->subprocess_env); >@@ -547,7 +547,7 @@ > > for (len = 0, i = 0; i < arr->nelts; i++) { > if (!strncmp(elts[i].key, "HTTP_", 5)) { >- len += strlen(elts[i].key) + strlen(elts[i].val) + 2; >+ len += strlen(elts[i].key) + strlen(elts[i].val) + 3; > } > } > >@@ -564,6 +564,7 @@ > *(((char*)buf_data)++) = ':'; > strcpy(buf_data, elts[i].val); > ((char*)buf_data) += strlen(elts[i].val); >+ *(((char*)buf_data)++) = '\r'; > *(((char*)buf_data)++) = '\n'; > } > } >@@ -575,7 +576,7 @@ > > if (!strcmp(variable_name, "ALL_RAW")) > { >- /* lf delimited, colon split, comma seperated and >+ /* crlf delimited, colon split, comma separated and > * null terminated list of the raw request header > */ > const apr_array_header_t *arr = apr_table_elts(r->headers_in); >@@ -583,7 +584,7 @@ > int i; > > for (len = 0, i = 0; i < arr->nelts; i++) { >- len += strlen(elts[i].key) + strlen(elts[i].val) + 2; >+ len += strlen(elts[i].key) + strlen(elts[i].val) + 4; > } > > if (*buf_size < len + 1) { >@@ -599,6 +600,7 @@ > *(((char*)buf_data)++) = ' '; > strcpy(buf_data, elts[i].val); > ((char*)buf_data) += strlen(elts[i].val); >+ *(((char*)buf_data)++) = '\r'; > *(((char*)buf_data)++) = '\n'; > } > *(((char*)buf_data)++) = '\0';
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 20656
: 6742