ASF Bugzilla – Attachment 9556 Details for
Bug 25497
Input tags generate invalid XHTML,
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Input Form taglib patch
Form.patch.txt (text/plain), 5.80 KB, created by
Ben Meadowcroft
on 2003-12-13 10:24:40 UTC
(
hide
)
Description:
Input Form taglib patch
Filename:
MIME Type:
Creator:
Ben Meadowcroft
Created:
2003-12-13 10:24:40 UTC
Size:
5.80 KB
patch
obsolete
>--- Form.orig 2003-12-12 09:39:28.000000000 +0000 >+++ Form.java 2003-12-12 23:13:07.000000000 +0000 >@@ -3,7 +3,7 @@ > * > * The Apache Software License, Version 1.1 > * >- * Copyright (c) 1999 The Apache Software Foundation. All rights >+ * Copyright (c) 1999 The Apache Software Foundation. All rights > * reserved. > * > * Redistribution and use in source and binary forms, with or without >@@ -11,7 +11,7 @@ > * are met: > * > * 1. Redistributions of source code must retain the above copyright >- * notice, this list of conditions and the following disclaimer. >+ * notice, this list of conditions and the following disclaimer. > * > * 2. Redistributions in binary form must reproduce the above copyright > * notice, this list of conditions and the following disclaimer in >@@ -19,15 +19,15 @@ > * distribution. > * > * 3. The end-user documentation included with the redistribution, if >- * any, must include the following acknowlegement: >- * "This product includes software developed by the >+ * any, must include the following acknowlegement: >+ * "This product includes software developed by the > * Apache Software Foundation (http://www.apache.org/)." > * Alternately, this acknowlegement may appear in the software itself, > * if and wherever such third-party acknowlegements normally appear. > * > * 4. The names "The Jakarta Project", "Tomcat", and "Apache Software > * Foundation" must not be used to endorse or promote products derived >- * from this software without prior written permission. For written >+ * from this software without prior written permission. For written > * permission, please contact apache@apache.org. > * > * 5. Products derived from this software may not be called "Apache" >@@ -53,7 +53,7 @@ > * information on the Apache Software Foundation, please see > * <http://www.apache.org/>. > * >- */ >+ */ > package org.apache.taglibs.input; > > import java.util.*; >@@ -63,7 +63,7 @@ > > /** > * >- * This class implements the <input:form> tag, which presents an >+ * This class implements the <input:form> tag, which presents an > * <form ... /> element. > * > * @version 0.90 >@@ -81,7 +81,7 @@ > private String beanId; // bean id to get default values from > private String method; // form method > private String encType; // form encType >- >+ > public int doStartTag() throws JspException { > try { > // get what we need from the page >@@ -89,7 +89,7 @@ > > // start building up the tag > out.print("<form method=\"" ); >- out.print( method != null ? method : "GET" ); >+ out.print( method != null ? method : "get" ); > out.print( "\" action=\"" ); > if ( action != null ) { > if ( action.length() > 0 && pageContext.getResponse() instanceof HttpServletResponse ) { >@@ -104,7 +104,7 @@ > out.print( "name=\"" + Util.quote(name) + "\" "); > } > if ( encType != null ) { >- out.print( "encType=\"" + encType + "\" " ); >+ out.print( "enctype=\"" + encType + "\" " ); > } > > // include any attributes we've got here >@@ -122,7 +122,7 @@ > } > return EVAL_BODY_INCLUDE; > } >- >+ > public int doEndTag() throws JspException { > try { > JspWriter out = pageContext.getOut(); >@@ -133,7 +133,7 @@ > } > return EVAL_PAGE; > } >- >+ > public void setName(String x) { > name = x; > } >@@ -141,15 +141,15 @@ > public void setAttributes(Map x) { > attributes = x; > } >- >+ > public void setAttributesText( String x ) { > attributesText = x; > } >- >+ > public void setBean( String x ) { > beanId = x; > } >- >+ > public String getBean() { > return beanId; > } >@@ -165,35 +165,35 @@ > public void setEncType(String x) { > encType = x; > } >- >+ > /** Getter for property name. > * @return Value of property name. > */ > public String getName() { return name; } >- >+ > /** Getter for property method. > * @return Value of property method. > */ > public String getMethod() { return method; } >- >+ > /** Getter for property encType. > * @return Value of property encType. > */ > public String getEncType() { return encType; } >- >+ > /** Getter for property attributesText. > * @return Value of property attributesText. > */ > public String getAttributesText() { return attributesText; } >- >+ > /** Getter for property attributes. > * @return Value of property attributes. > */ > public Map getAttributes() { return attributes; } >- >+ > /** Getter for property action. > * @return Value of property action. > */ > public String getAction() { return action; } >- >+ > } >--- Form.orig 2003-12-12 09:39:28.000000000 +0000 >+++ Form.java 2003-12-13 09:08:20.000000000 +0000 >@@ -89,7 +89,7 @@ > > // start building up the tag > out.print("<form method=\"" ); >- out.print( method != null ? method : "GET" ); >+ out.print( method != null ? method : "get" ); > out.print( "\" action=\"" ); > if ( action != null ) { > if ( action.length() > 0 && pageContext.getResponse() instanceof HttpServletResponse ) { >@@ -104,7 +104,7 @@ > out.print( "name=\"" + Util.quote(name) + "\" "); > } > if ( encType != null ) { >- out.print( "encType=\"" + encType + "\" " ); >+ out.print( "enctype=\"" + encType + "\" " ); > } > > // include any attributes we've got here
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 25497
:
9555
| 9556 |
9557
|
9558
|
9559