Summary: | Corrupt log lines at high volumes | ||
---|---|---|---|
Product: | Apache httpd-2 | Reporter: | Adam Sussman <adam.sussman> |
Component: | mod_log_config | Assignee: | Apache HTTPD Bugs Mailing List <bugs> |
Status: | CLOSED FIXED | ||
Severity: | normal | ||
Priority: | P3 | ||
Version: | 2.0-HEAD | ||
Target Milestone: | --- | ||
Hardware: | Other | ||
OS: | other |
Description
Adam Sussman
2003-12-15 01:10:26 UTC
A thread mutex should be good enough for handling the buffer and possibly flushing. Each process would be atomically appending a set of complete trace records to the file, and that doesn't have to be handled explicitly by mod_log_config. With buffered logs there will be a much higher incidence of out of order records, but that can happen already. I wonder if the big picture is that for a threaded MPM config you're better off shoving everything to a piped logger to handle in its simple way rather than adding serious mutex contention to the web server. Still, the code to make it functionally correct is relatively simple so it should be implemented and the user should get to decide which is more appropriate. fix just committed to Apache 2.1-dev... I'll propose it for backport once folks have had a chance to look at it Thanks for your report, and thanks for using Apache! |